psuedo class first-child error #3652
Conversation
| state = { inputValue: '' }; | ||
| handleInputChange = (newValue: string) => { | ||
| const inputValue = newValue.replace(/\W/g, ''); | ||
| //const inputValue = newValue.replace(/\W/g, ''); |
There was a problem hiding this comment.
for a special character, so we can enter them same as in promise
| @@ -97,7 +97,7 @@ const Heading = props => { | |||
| } | |||
| const css = { | |||
| marginTop: 0, | |||
| '&:not(:first-child)': { marginTop: 30 }, | |||
| '&:not(:first-of-type)': { marginTop: 30 }, | |||
There was a problem hiding this comment.
Is there an open issue we could link for this fix?
There was a problem hiding this comment.
I guess no. I found it in the console panel
ankush29
force-pushed
the
master
branch
2 times, most recently
from
7640d87
to
e6e09e9
Compare
|
When is this going to be merged? |
|
@JedWatson can we merge this? |
|
Hey @ankush29, thanks for the PR! This fix was also included in #2284 which has been merged now tbh it's much easier to review and merge PRs that deal with a single isolated issue, so I really appreciate your contributions here, but it would be helpful for the other things you included if you can open separate PRs explaining the rationale for each - otherwise it's hard to know what you meant to change and why, and merge them individually. Thanks again 🙂 |
|
@JedWatson this PR also included code to focus the selected option, which doesn't seems to be part of #2284 or any other previous commit. I would be great to have this - or at least something else working, also included. |
|
@ankush29 would you be willing to make a separate PR for the focus the selected option issue? I would be willing to do that as well, but don't want to steal the credits for it. |
|
Sure! I will do.
…On Wed, Oct 16, 2019, 8:20 PM Sebastiaan ten Pas ***@***.***> wrote:
@ankush29 <https://github.com/ankush29> would you be willing to make a
separate PR for the focus the selected option issue? I would be willing to
do that as well, but don't want to steal the credits for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3652?email_source=notifications&email_token=ACZ7XE3AIVOJDX73F2VWUC3QO4SZ3A5CNFSM4H3ZFZJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBMYUKY#issuecomment-542738987>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ7XEYCIZAAJI42BIHXW5LQO4SZ3ANCNFSM4H3ZFZJQ>
.
|
|
Hey,
I have created a separate pull request :
a67c548
regards
On Wed, Oct 16, 2019 at 9:06 PM Ankush saini <saini.ankush29@gmail.com>
wrote:
… Sure! I will do.
On Wed, Oct 16, 2019, 8:20 PM Sebastiaan ten Pas ***@***.***>
wrote:
> @ankush29 <https://github.com/ankush29> would you be willing to make a
> separate PR for the focus the selected option issue? I would be willing to
> do that as well, but don't want to steal the credits for it.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#3652?email_source=notifications&email_token=ACZ7XE3AIVOJDX73F2VWUC3QO4SZ3A5CNFSM4H3ZFZJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBMYUKY#issuecomment-542738987>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACZ7XEYCIZAAJI42BIHXW5LQO4SZ3ANCNFSM4H3ZFZJQ>
> .
>
|
|
@JedWatson any update on this PR? |
|
Any news about the pending PR here? |
|
This PR is closed and won't be merged. It's split out over other PR's. Have a look at #3868 for example. Unfortunately the maintainers didn't have time yet to have a look at that one, so we just patiently have to wait. |
No description provided.