Use react/lib/EventListener instead of document.addEventListener #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xcatliu please see the CONTRIBUTOR file, you should only edit files in |
|
The React team has made it clear that using React internals in other packages is not safe; as tempting as it is to reach in and access these utils, we should find a better way. |
|
Closing, will open a relevant issue though. @xcatliu please re-open if you rebase and submit a new/different fix. |
|
@dcousens @JedWatson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.addEventListenerdoesn't work on IE8.Use
react/lib/EventListenerinstead ofdocument.addEventListenerwill solve this problem.