-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defaultPrevented issue with react-beautiful-dnd #5176
Comments
Hey. That was my initial proposal - usage of internal flag. See this conversation Possibly this case would require some other kind of patch. |
Can reproduce also after upgrading to 5.3. |
@Rall3n @rkulinski Is there a plan to remove the |
Is there any solution to that one? Still issue with v5.6.0 |
It would be great if there was a fix for this, I did work up a fiddle to get this working with react-beautiful-dnd, not ideal, but workable if any one else is running into this. https://codesandbox.io/s/vertical-list-forked-tqwc9v?file=/index.js |
I found another workaround in react-beautiful-dnd. It's still ugly but I'm not yet sure what react-select can do to accommodate the case when a library like react-beautiful-dnd binds to global |
Can someone tell me why we can't select text by double click if text is inside draggable div? |
Hi everyone, |
This is intended to be a temporal fix, as I think a better solution must be developed. Referenced issues: JedWatson#5833, JedWatson#5176 Another PRs abaout this: JedWatson#5842
hello. updated now from 2 to 5. found this error when using react-select under a react-beautiful-dnd |
Since |
Since the following change 150c020
React Select can no longer be opened through
onControlMouseDown
and theevent.defaultPrevented
is alwaystrue
when the component is rendered inside react-beautiful-dnd.CSB: https://codesandbox.io/s/vertical-list-forked-mucu2g?file=/index.js
@rkulinski can you consider using internal flag instead of
defaultPrevented
(53cc8ce) to ensure that the event is captured by dropdown indicator ?The text was updated successfully, but these errors were encountered: