Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES Module Export #105

Merged
merged 1 commit into from
Sep 10, 2017
Merged

ES Module Export #105

merged 1 commit into from
Sep 10, 2017

Conversation

jednano
Copy link

@jednano jednano commented Dec 10, 2016

Fixes #99

See #99 (comment)

@jednano jednano mentioned this pull request Dec 10, 2016
Merged
@dcousens
Copy link
Collaborator

concept ACK, ping @JedWatson

@jednano
Copy link
Author

jednano commented Dec 10, 2016

@dcousens fixed!

@jednano jednano mentioned this pull request Dec 10, 2016
Closed
@jednano
Copy link
Author

jednano commented Dec 10, 2016

@JedWatson please refer to #106, which demonstrates the problem and proves this PR fixes it. Thank you!

@aldendaniels
Copy link

👍 Just ran into this using classnames in TypeScript

@ebenoist
Copy link

ebenoist commented Jun 7, 2017

Can this please be merged? Its a simple fix and helps folks out who are using typescript.

@zemd
Copy link

zemd commented Jun 12, 2017

just made a quick port of this lib with custom builds for es6 and others https://github.com/zemd/classnames2

@kingcoconut
Copy link

kingcoconut commented Sep 7, 2017 •
edited
Loading

@JedWatson Can we please have this merged

@kingcoconut
Copy link

@dcousens are you able to merge?

@dcousens
Copy link
Collaborator

I can merge, I can't release.

@dcousens dcousens merged commit 34a05a5 into JedWatson:master Sep 10, 2017
@dcousens dcousens added the bug label Sep 10, 2017
@octatone
Copy link

Is this module abandoned?

@jednano jednano deleted the es-module-export branch September 21, 2017 16:38
@dcousens
Copy link
Collaborator

@JedWatson ?

This was referenced Apr 22, 2018
Closed
Closed
@jednano
Copy link
Author

jednano commented Apr 25, 2018 •
edited
Loading

I published @jedmao/classnames, version 2.2.6 to fix this issue, if anyone is interested. Please note that this is my own scoped package and I am not the original author of this repo. I do, however, happen to have the same name, Jed 😀

@iki
Copy link

iki commented Jun 8, 2018

@JedWatson any way to release it? It's a breaker when using https://sucrase.io/ for fast transpile of typescript.

@iki iki mentioned this pull request Jun 8, 2018
Closed
@JedWatson
Copy link
Owner

Sure, sorry for the delay. I'll sort this out and get a new version published.

@JedWatson
Copy link
Owner

Done

@dcousens
Copy link
Collaborator

dcousens commented Jun 8, 2018

@JedWatson 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jednano @dcousens @aldendaniels @ebenoist @zemd @kingcoconut @octatone @iki @JedWatson