AGM Location Change First PR #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JazzarKarim
commented
Oct 20, 2023
| @@ -36,7 +36,7 @@ export default class DetailComment extends Vue { | |||
| get rules (): Array<(val) => boolean | string> { | |||
| // include whitespace in maximum length check | |||
| return [ | |||
| val => (val && val.trim().length > 0) || 'Detail is required.', | |||
| val => (val && val.trim().length > 0) || this.textRequiredErrorMsg, | |||
There was a problem hiding this comment.
Using this new prop to show "Reason is required" instead of "Detail is required"
JazzarKarim
commented
Oct 20, 2023
| @@ -113,7 +116,6 @@ export default class DetailComment extends Vue { | |||
| // Move the placeholder and input text from the edges. | |||
| :deep() { | |||
| .theme--light.v-input input, .theme--light.v-input textarea { | |||
| background-color: $gray1; | |||
There was a problem hiding this comment.
The component had a weird behavior/color:
I don't know if you can see it haha but the background is a little bit messed up (2 colors). This fixes that.
JazzarKarim
commented
Oct 20, 2023
| @@ -90,14 +100,15 @@ | |||
| </p> | |||
| </header> | |||
|
|
|||
| <div :class="{ 'invalid-section': !agmYearValid && showErrors }"> | |||
There was a problem hiding this comment.
I don't believe we need here a red border for everything. I don't see this type of behavior in other local filings. I think the red border should be to what's invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#18161
Description of changes:
Note: In order to help with reviewing and not create one huge PR, I'll be doing the work in multiple small PRs. I'm also merging to main of my forked repo (not to main bcgov repo).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).