Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failure
before committing.Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.
Polar GP example was non-continuous through 0 - 2\pi. When defining the half-period constant c as follows:
c
was still training as a parameter during optimisation and wasn't being considered static, resulting in an invalid Polar GP (I believe). Therefore I moved the definition ofc
to within the call method of the kernel, maintaining it as a constant during hyper-parameter optimisation. I'm not 100% sure on why this behaviour is happening, with training a constant, but this fixes it.I have changed the docs to reflect this, also fixed a minor typo (
circular_posterior
), and changed linewidth of the fill_between to be 0 so there wasn't a funky line between 0 and 2/pi.Issue Number: N/A