Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite recursion in DefaultExchangeRate.hashCode() #146

Closed
sgrimm-sg opened this issue Jan 4, 2017 · 2 comments
Closed

Infinite recursion in DefaultExchangeRate.hashCode() #146

sgrimm-sg opened this issue Jan 4, 2017 · 2 comments
Assignees
@atsticks
Milestone
1.2

Comments

@sgrimm-sg
Copy link
Contributor

DefaultExchangeRate.hashCode() includes the exchange rate chain in the list of objects whose hash codes are combined to form the rate's hash code. Unfortunately, when no chain is specified explicitly in the builder, the default chain includes a reference to this, so hashCode() ends up calling itself until the stack overflows.
@sgrimm-sg sgrimm-sg mentioned this issue Jan 4, 2017
Merged
@keilw
Copy link
Member

keilw commented Jan 4, 2017

This shall only be closed as soon as both https://github.com/JavaMoney/jsr354-ri/ and https://github.com/JavaMoney/jsr354-ri-bp/ are addressed accordingly.

@atsticks atsticks self-assigned this Jul 11, 2017
atsticks added a commit to JavaMoney/jsr354-api that referenced this issue Jul 30, 2017
@atsticks
JavaMoney/jsr354-ri/issues/146 Fixed hashCode/equals.
9463a6e
atsticks added a commit to JavaMoney/jsr354-ri-bp that referenced this issue Jul 30, 2017
@atsticks
JavaMoney/jsr354-ri/issues/146 Fixed hashCode/equals.
e341590
atsticks added a commit that referenced this issue Jul 30, 2017
@atsticks
/issues/146 Fixed hashCode/equals.
e83cb97
atsticks added a commit to JavaMoney/jsr354-api-bp that referenced this issue Jul 30, 2017
@atsticks
JavaMoney/jsr354-ri/issues/146 Fixed hashCode/equals.
92a2fa0
@atsticks atsticks added this to the 1.2 milestone Jul 30, 2017
@atsticks
Copy link
Member

Fixed in master: RI, RI-bap, API, API-BP.

@dependabot-preview dependabot-preview bot mentioned this issue May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atsticks atsticks

Labels
None yet
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
3 participants
@keilw @atsticks @sgrimm-sg