Syncnew #2
Merged
Syncnew #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…io-rs#786) * Allow file descriptor be generated without --include_source_info The file descriptor sets generated by rules_proto in bazel don't have this by default, so this allows some flexibility for users to reuse results that are already available to them. It's fairly trivial adjustment so it seemed reasonable to me to allow the flexibility. * revert breaking changes and add default
…okio-rs#803) * Fix issue with negative nanos in Duration::try_from(), and add a unit test * add proptest for negative nanos * PR comment: remove spurious dbg
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
This commit adds two new compile functions that allow passing a `FileDescriptorSet` and it will generate the Rust code. This allows users to use libraries like `protox` directly and in an ergonomic way.
tokio-rs#828) * Add existing roundtrip test to Kani CI * Bump up Kani version * Remove `v` from GA version
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
This library will fail to build with the following error when checked
out into a directory not named exactly `prost`:
error: failed to load manifest for workspace member `/home/alex/src/prost-rs/tests/single-include`
Caused by:
failed to load manifest for dependency `prost`
Caused by:
failed to read `/home/alex/src/prost/Cargo.toml`
Caused by:
No such file or directory (os error 2)
This is because the `single-include` test depends on `prost` with the
path `../../../prost`. This patch fixes the issue by correcting the path
to `../..`.
This allows the user to request boxing of specific fields. This is useful for enum types that might have variants of very different size.
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
# Conflicts: # .github/workflows/continuous-integration-workflow.yaml # Cargo.toml # prost-build/src/lib.rs
Merged
Jasperav
added a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.