Add IServiceProviderIsService to ServiceRegistry #355
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maryamariyan was showing me this code because it looks like
IServiceProviderIsService
isn't being properly registered in the ServiceRegistry. I'm not sure this works, but it should be closer to working. I copied(IServiceProviderIsService)s.GetRequiredService<IContainer>()
from https://github.com/JasperFx/lamar/blob/v8.0.1/src/Lamar.Microsoft.DependencyInjection/HostBuilderExtensions.cs#L90 but it doesn't look likeIContainer
implementsIServiceProviderIsService
.We'll want to add tests, ifdef, and remove the dead code before merging this though.