fix: broken fonts and more optimisations #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Jarmos-san
changed the title
Jarmos-san
requested changes
Feb 18, 2024
There was a problem hiding this comment.
Thanks for providing the fix, I had totally missed it before! Btw if you can, could you also change the font files from .ttf to a more optimised and recommended .woff2 file format?
Fontsource library is being used now for fonts so the concern about optimization will be taken care of by the npm library. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Jarmos-san
approved these changes
Feb 19, 2024
Jarmos-san
deleted the
350-bug-poppins-font-not-rendering-properly-on-the-view-port
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the Poppins font's format in the assets directory. Fixing this format fixes the font in the viewport (#350) , the solution is based on this Stack Overflow thread.
Before:
After:
