Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-lotto] haon.lee(이민성) 미션 제출합니다. #3

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

msung99
Copy link

@msung99 msung99 commented Oct 1, 2024

클래스 다이어그램

객체지향 프로그래밍을 준수하고자 하니, 시간이 생각보다 걸렸습니다. 다들 파이팅입니다!

image

@msung99 msung99 self-assigned this Oct 1, 2024
@msung99 msung99 changed the title haon.lee(이민성) 로또 미션 제출합니다. [java-lotto] haon.lee(이민성) 미션 제출합니다. Oct 1, 2024
Copy link

@alreadysons alreadysons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전략적으로 나눠서 관리하신 부분이 인상깊었습니다!!
고생하셨습니다!! 👍

@@ -1,5 +1,6 @@
package lotto;

import lotto.domain.Lotto;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 부분이 더 추가되었으면 좋겠습니다!!

Copy link
Member

@yohanii yohanii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다👍
객체 나누는데 도움이 되었어요

@@ -0,0 +1,31 @@
package lotto.domain;

public class WinningLotto {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lotto를 extends 하는 방식도 좋을 것 같습니다!
두 방식에 어떤 차이가 있는지 저도 고민해봐야겠습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants