Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make agent configurable for underlying http(s) request #152

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat: make agent configurable for underlying http(s) request #152

merged 1 commit into from
Apr 15, 2024

Conversation

trolfsmeier-di
Copy link
Contributor

@trolfsmeier-di trolfsmeier-di commented Apr 11, 2024 •
edited
Loading

We want to provide an http agent to the underlying requests to keep connections alive and therefore save sockets.

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Apr 11, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@JaniAnttonen JaniAnttonen added Sweep and removed Sweep labels Apr 15, 2024
JaniAnttonen
JaniAnttonen approved these changes Apr 15, 2024
View reviewed changes
Copy link
Owner

@JaniAnttonen JaniAnttonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JaniAnttonen JaniAnttonen merged commit 8d8337d into JaniAnttonen:development Apr 15, 2024
@baderdean baderdean mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaniAnttonen JaniAnttonen JaniAnttonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trolfsmeier-di @JaniAnttonen