Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Enable replaceTimestamp by default #145

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Sweep: Enable replaceTimestamp by default #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0d23d2
feat: Updated index.js
sweep-ai[bot] Mar 29, 2024
e279641
feat: Updated README.md
sweep-ai[bot] Mar 29, 2024
0031d4d
Merge main into sweep/enable_replacetimestamp_by_default
sweep-ai[bot] Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ LokiTransport() takes a Javascript object as an input. These are the options tha
| `json` | Use JSON instead of Protobuf for transport | true | false |
| `batching` | If batching is not used, the logs are sent as they come | true | true |
| `clearOnError` | Discard any logs that result in an error during transport | true | false |
| `replaceTimestamp` | Replace any log timestamps with Date.now() | true | false |
| `replaceTimestamp` | Replace any log timestamps with Date.now(). Warning: Disabling `replaceTimestamp` may result in logs failing to upload due to recent changes in the upstream Loki project. It is recommended to leave this option enabled unless you have a specific reason to disable it. | true | true |
| `labels` | custom labels, key-value pairs | { module: 'http' } | undefined |
| `format` | winston format (https://github.com/winstonjs/winston#formats) | simple() | undefined |
| `gracefulShutdown` | Enable/disable graceful shutdown (wait for any unsent batches) | false | true |
Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class LokiTransport extends Transport {
batching: options.batching !== false,
clearOnError: options.clearOnError,
onConnectionError: options.onConnectionError,
replaceTimestamp: options.replaceTimestamp,
replaceTimestamp: options.replaceTimestamp !== false,
gracefulShutdown: options.gracefulShutdown !== false,
timeout: options.timeout
})
Expand Down