Use ReactModule annotation from react-native 0.58 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @staltz, Thank you for the PR. I still have to run some tests but it LGTM. |
jaimecbernardo
pushed a commit
that referenced
this pull request
Apr 15, 2019
As react-native 0.58, native modules now need the ReactModule Java annotation. PR-URL: #9 Refs: https://github.com/react-native-community/react-native-releases/blob/72dde0d270685f44d2f827544267502dcb0b6235/CHANGELOG.md#058 Reviewed-By: Jaime Bernardo <jaime@janeasystems.com>
jaimecbernardo
approved these changes
Apr 15, 2019
softdevjs7
added a commit
to softdevjs7/nodejs-mobile-react-native
that referenced
this pull request
Sep 30, 2022
As react-native 0.58, native modules now need the ReactModule Java annotation. PR-URL: JaneaSystems/nodejs-mobile-react-native#9 Refs: https://github.com/react-native-community/react-native-releases/blob/72dde0d270685f44d2f827544267502dcb0b6235/CHANGELOG.md#058 Reviewed-By: Jaime Bernardo <jaime@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As react-native 0.58 release notes mention, these native modules now need a Java annotation.
I noticed that without this change, a runtime crash occurs.