Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

TypeScript type declaration file #46

Closed
geopic opened this issue Jan 19, 2020 · 4 comments
Closed

TypeScript type declaration file #46

geopic opened this issue Jan 19, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on

Comments

@geopic
Copy link

geopic commented Jan 19, 2020

Similar to my proposal left on your objection-authorize repo, would you be willing to let me add a type declaration file to this project?
@JaneJeon
Copy link
Owner

Same as in the other repo, please, I'd love your help!

This library is probably a lot simpler than the other one (not just in terms of what it does, but also in terms of the actual .d.ts file).

Please, feel free to make a PR!

@JaneJeon JaneJeon added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 21, 2020
geopic added a commit to geopic/objection-hashid that referenced this issue Jan 24, 2020
@geopic
Add types declaration file (resolve JaneJeon#46)
30af6a8
@simo-eskalera
Copy link

Has this landed? It would be a great addition!

@geopic
Copy link
Author

geopic commented Feb 3, 2020

Not yet @simo-eskalera

@JaneJeon JaneJeon mentioned this issue Feb 4, 2020
Closed
@simoami simoami mentioned this issue Feb 4, 2020
Closed
@JaneJeon JaneJeon linked a pull request Feb 5, 2020 that will close this issue
Add types declaration file (resolve #46) #51
Closed
olavim added a commit to olavim/objection-hashid that referenced this issue Feb 19, 2020
@olavim
Add type declarations (resolve JaneJeon#46)
ea096fc
@JaneJeon JaneJeon linked a pull request Oct 4, 2020 that will close this issue
Add type declarations (resolve #46) #61
Closed
@JaneJeon JaneJeon added the wontfix This will not be worked on label Oct 4, 2020
@JaneJeon
Copy link
Owner

JaneJeon commented Oct 4, 2020

For now, we'll leave this issue alone...

@JaneJeon JaneJeon closed this as completed Oct 4, 2020
@JaneJeon JaneJeon pinned this issue Oct 4, 2020
This was referenced Dec 27, 2020
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
3 participants
@JaneJeon @geopic @simo-eskalera