Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MaxDepth when used with ToObject inside of a JsonConverter #2505

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Fix MaxDepth when used with ToObject inside of a JsonConverter #2505

merged 4 commits into from
Mar 31, 2021

Conversation

JamesNK
Copy link
Owner

@JamesNK JamesNK commented Mar 26, 2021 •
edited
Loading

Fixes #2501

@JamesNK JamesNK changed the title Additional MaxDepth tests Fix MaxDepth when used with ToObject inside of a JsonConverter Mar 27, 2021
@JamesNK JamesNK mentioned this pull request Mar 27, 2021
Closed
@JamesNK JamesNK merged commit f7e7bd0 into master Mar 31, 2021
@JamesNK JamesNK deleted the jamesnk/maxdepth-fixes branch March 31, 2021 02:57
@davidefu davidefu mentioned this pull request Aug 7, 2021
Closed
@Kiril1512
Copy link

Hello @JamesNK , when this is planned to be released? Thank you!

@PatoMickey
Copy link

Hello @JamesNK!
It's been a long time since this problem was solved.
I was forced to upgrade to the NewtonSoft latest version and this is a major problem for me (and a lot of other people I suppose).
When do you think this is going to be published?
Regards

@EricDahlvang EricDahlvang mentioned this pull request Jun 27, 2022
Closed
@andreas-sommer-engenious
Copy link

In with version is this solved? I installed 13.0.1 and it's already there.
Regards
Andreas

sousapedro pushed a commit to sousapedro/Newtonsoft.Json-for-Unity that referenced this pull request Feb 21, 2023
@JamesNK @sousapedro
Fix MaxDepth when used with ToObject inside of a JsonConverter (James…
de26c28 
…NK#2505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MaxDepth default value of null or 100 is not respected
4 participants
@JamesNK @Kiril1512 @PatoMickey @andreas-sommer-engenious