enable source linking #1555
Closed
enable source linking #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use SourceLink 2 * do source linking on AppVeyor * skip deleting workdir if on appveyor * set workingSourceDir * no need to copy source files * just source files * fixed build * make sure it is restored * skip tests & IncludeSource * input * get rid of unnecessary changes * disable dotnet-install to see if that is causing no pdb in nupkg * it was the installed dotnet that was messing up pack * use 2.7.3
15 tasks
Which ones? I'll consider it if it becomes common. |
|
Here is a video demo for a source link enabled Newtonsoft.Json: |
Soon, all of them. Here is what Microsoft decided: |
|
any updates? When will this be merged? |
|
I'll be looking enabling sourcelink in the next release. |
|
I can help update it to dotnet/sourcelink if you would like |
|
Replaced by #1746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much has changed since 2013 #103. That was source indexing with Windows PDB files. Instead, this pull request enables source linking of the Portable PDB files and adds them to the main nupkg to be published to NuGet Gallery. SourceLink was added to the .NET Foundation. Several Microsoft projects are expected to ship packages this way in the VS 15.6 time-frame.
Adding the portable pdb files to the nupkg increased it by 847 KB, about 0.8 MB.
The .symbols.nupkg size is not affected. However, it becomes obsolete with source linking. You can remove it by removing
/p:IncludeSource=true.One reason for producing this is we would like to troubleshoot some performance issues by including source linked portable pdb files with Ionide ionide/FsAutoComplete#264.