Code

NTO-180 merged upstream changes#10

Code

Merged

akhumphrey merged 151 commits intomasterJamesAndJamesFulfilment/symfony1:masterfrom integrationJamesAndJamesFulfilment/symfony1:integrationCopy head branch name to clipboardMar 28, 2024

+69,293-75,641

Commits

Commits on Oct 5, 2022

• Add docker compose

  Show description for e8cbc9d
  

  alquerci

  and

  thirsch

  committed
  e8cbc9d

  Copy full SHA for e8cbc9d

Commits on Nov 25, 2022

• Merge pull request FriendsOfSymfony1#262 from alquerci/add-docker-compose

  Show description for 6b82513
  thePanz

  authored
  6b82513

  Copy full SHA for 6b82513

• Use GitHub actions for Continuous Integration tests

  Show description for 32b2a4b
  thePanz

  committed
  32b2a4b

  Copy full SHA for 32b2a4b

• Fix test for /bin/ls file mimetype guessing, using application/x-pie-executable

  thePanz

  committed
  21b7381

  Copy full SHA for 21b7381

• Merge pull request FriendsOfSymfony1#268 from FriendsOfSymfony1/switch-to-github-actions

  Show description for d0e631d
  thePanz

  authored
  d0e631d

  Copy full SHA for d0e631d

• PHP 8.1 > internal_method_return_types

  Show description for 245c7cc
  

  Tybaze

  authored and

  thePanz

  committed
  245c7cc

  Copy full SHA for 245c7cc

• PHP 8.1 > Serializable Phase Out

  Show description for 6401fcc
  

  Tybaze

  authored and

  thePanz

  committed
  6401fcc

  Copy full SHA for 6401fcc

• PHP 8.0 & 8.1 > Deprecated of null to non-nullable internal function parameters

  Show description for 029b0e7
  

  Tybaze

  authored and

  thePanz

  committed
  029b0e7

  Copy full SHA for 029b0e7

• PHP 8.1 > strftime deprecated.

  Show description for dcb1ce3
  

  Tybaze

  authored and

  thePanz

  committed
  dcb1ce3

  Copy full SHA for dcb1ce3

• PHP 8.1 > Unit Test

  Show description for 8450b13
  

  Tybaze

  authored and

  thePanz

  committed
  8450b13

  Copy full SHA for 8450b13

• Fix lime message: "An uncaught exception has been thrown" do not have "error" value

  Show description for 9cb7fb4
  

  Tybaze

  authored and

  thePanz

  committed
  9cb7fb4

  Copy full SHA for 9cb7fb4

• PHP 8.1 > uasort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero

  

  Tybaze

  authored and

  thePanz

  committed
  25a5e71

  Copy full SHA for 25a5e71

• Fix ValueError: DOMDocument::loadHTML(): Argument #1 ($source) must not be empty

  

  Tybaze

  authored and

  thePanz

  committed
  09fc710

  Copy full SHA for 09fc710

• PHP 8.0 > fread()/count() behavior

  Show description for df2ec65
  

  Tybaze

  authored and

  thePanz

  committed
  df2ec65

  Copy full SHA for df2ec65

• Fix Declaration of sfPearRestTest::downloadHttp($url, $lastmodified = null, $accept = false) must be compatible with sfPearRest::downloadHttp($url, $lastmodified = null, $accept = false, $channel =…

  Show description for 42112ab
  

  Tybaze

  authored and

  thePanz

  committed
  42112ab

  Copy full SHA for 42112ab

• PHP 8.0 > mktime update

  Show description for 29ab2a7
  

  Tybaze

  authored and

  thePanz

  committed
  29ab2a7

  Copy full SHA for 29ab2a7

• Fix sfWebResponse->getContentType() return a string not an array

  

  Tybaze

  authored and

  thePanz

  committed
  12f7b4c

  Copy full SHA for 12f7b4c

• Fix sfDoctrineTester, string cannot be accessed as array

  

  Tybaze

  authored and

  thePanz

  committed
  cae793e

  Copy full SHA for cae793e

• PHP 8.0 > Fix is_numeric behavior with trailing empty char

  Show description for 7341b43
  

  Tybaze

  authored and

  thePanz

  committed
  7341b43

  Copy full SHA for 7341b43

• PHP 8.0 > String to Number Comparison.

  Show description for b191cb8
  

  Tybaze

  authored and

  thePanz

  committed
  b191cb8

  Copy full SHA for b191cb8

• PHP 8.1 > Change support to PHP 8.1

  

  Tybaze

  authored and

  thePanz

  committed
  956cb1a

  Copy full SHA for 956cb1a

• Fix UnitTest application/x-sharedlib

  Show description for b0cb92e
  

  Tybaze

  authored and

  thePanz

  committed
  b0cb92e

  Copy full SHA for b0cb92e

• PHP 8.1 > mysqli_report revert to off

  Show description for bb22141
  

  Tybaze

  authored and

  thePanz

  committed
  bb22141

  Copy full SHA for bb22141

• Refactor code and apply Coding Style fixes

  

  Tybaze

  authored and

  thePanz

  committed
  d0d0d12

  Copy full SHA for d0d0d12

• PHP 8.1 > Better MYSQLI_REPORT_OFF implementations for php8.1 compat

  Show description for 01fadb9
  

  Tybaze

  authored and

  thePanz

  committed
  01fadb9

  Copy full SHA for 01fadb9

• PHP 8.1 > remove full_path from uploads added on PHP v8.1

  

  mentalstring

  authored and

  thePanz

  committed
  3bb8339

  Copy full SHA for 3bb8339

• Fix use of null on string parameter on multiple classes

  

  mentalstring

  authored and

  thePanz

  committed
  7798328

  Copy full SHA for 7798328

• Github Actions: enable testing on PHP v8.0 and v8.1 (for PRs too)

  thePanz

  committed
  1e9b188

  Copy full SHA for 1e9b188

• Merge pull request FriendsOfSymfony1#266 from Tybaze/compat_php8.1

  Show description for 071b8bf
  thePanz

  authored
  071b8bf

  Copy full SHA for 071b8bf

Commits on Dec 13, 2022

• test environment for php 8.2

  thirsch

  committed
  fa161a1

  Copy full SHA for fa161a1

• PHP 8.2 > Using ${var} in strings is deprecated, use {$var} instead.

  thirsch

  committed
  f6d779c

  Copy full SHA for f6d779c

• PHP 8.2 > Creation of dynamic property Class::$property is deprecated

  thirsch

  committed
  d89618f

  Copy full SHA for d89618f

• PHP 8.0 > Uncaught ArgumentCountError: Too few arguments to function

  thirsch

  committed
  89c24cf

  Copy full SHA for 89c24cf

• PHP 8.0 > Trying to access array offset on value of type bool

  thirsch

  committed
  754c940

  Copy full SHA for 754c940

• PHP 8.0 > Passing null to parameter #1 ($haystack) of type string is deprecated

  thirsch

  committed
  13bfee2

  Copy full SHA for 13bfee2

Commits on Jan 9, 2023

• Merge pull request FriendsOfSymfony1#274 from vemaeg/feature/php-8.2-changes

  Show description for 6f50a31
  thePanz

  authored
  6f50a31

  Copy full SHA for 6f50a31

• set symfony version to 1.5.15-dev

  thirsch

  committed
  5d94af7

  Copy full SHA for 5d94af7

• Update(version) Set symfony version to 1.5.15-dev

  thePanz

  authored
  7ad07e0

  Copy full SHA for 7ad07e0

• PHP 8.0 > Class name must be a valid object or a string in case the controller does not exist.

  thirsch

  committed
  4820ada

  Copy full SHA for 4820ada

• PHP 8.0 > Fix undefined array key

  thirsch

  committed
  c55d53c

  Copy full SHA for c55d53c

• PHP 8.1 > Fix some more null on string parameter

  thirsch

  committed
  8b81a56

  Copy full SHA for 8b81a56

Commits on Jan 10, 2023

• Merge pull request FriendsOfSymfony1#272 from vemaeg/feature/more-php-8.1-fixes

  Show description for 9bba8c5
  thePanz

  authored
  9bba8c5

  Copy full SHA for 9bba8c5

• Prepared release 1.5.15

  thirsch

  committed
  e432434

  Copy full SHA for e432434

Commits on Jan 12, 2023

• Merge pull request FriendsOfSymfony1#275 from vemaeg/feature/release-preparations

  Show description for a72247f
  thePanz

  authored
  a72247f

  Copy full SHA for a72247f

• Add(changelog) Add v1.5.15 release date to Changelog file

  thePanz

  committed
  9945f3f

  Copy full SHA for 9945f3f

• Add(versioning) Add v1.5.16-dev as next release

  thePanz

  committed
  31d2c60

  Copy full SHA for 31d2c60

Commits on Jan 13, 2023

• Fix(deprecations) Fix deprecations in sfMessageSource_Aggregate (FriendsOfSymfony1#277)

  Show description for 2c5a4d6
  thePanz

  authored
  2c5a4d6

  Copy full SHA for 2c5a4d6

Commits on Feb 22, 2023

• Add(linting) Add code linting to GitHub workflow, use php-cs-fixer

  

  connorhu

  authored and

  thePanz

  committed
  ffbbce6

  Copy full SHA for ffbbce6

• Fix(php-cs) Fix php-cs styles according to configuration

  thePanz

  committed
  2cbd557

  Copy full SHA for 2cbd557

Commits on Mar 9, 2023

• Add(gitattributes) Add .gitattributes to repository

  thePanz

  committed
  dc824de

  Copy full SHA for dc824de

Commits on Sep 20, 2023

• imported upstream php-cs-fixer configuration

  akhumphrey

  committed
  abdecd7

  Copy full SHA for abdecd7

• initial pass of php-cs-fixer

  akhumphrey

  committed
  44c6bc6

  Copy full SHA for 44c6bc6

Commits on Sep 21, 2023

• updated config

  akhumphrey

  committed
  1bfa5f3

  Copy full SHA for 1bfa5f3

• updated config

  akhumphrey

  committed
  0d59d3e

  Copy full SHA for 0d59d3e

• updated config

  akhumphrey

  committed
  72c0635

  Copy full SHA for 72c0635

• updated config

  akhumphrey

  committed
  472854c

  Copy full SHA for 472854c

• Merged remote tracking branch 'upstream/master' into integration

  akhumphrey

  committed
  3fce81d

  Copy full SHA for 3fce81d

Commits on Oct 10, 2023

• imported routing fixes from master

  akhumphrey

  committed
  96d2848

  Copy full SHA for 96d2848

• Merged branch 'master' into integration

  akhumphrey

  committed
  ebb5e32

  Copy full SHA for ebb5e32

• removed 7.4 and 8.0 test targets

  akhumphrey

  committed
  57ca872

  Copy full SHA for 57ca872

• fixed long_to_shorthand_operator warnings

  akhumphrey

  committed
  a5cfe0d

  Copy full SHA for a5cfe0d

Commits on Oct 15, 2023

• temporarily disabled testing

  akhumphrey

  committed
  aaf2729

  Copy full SHA for aaf2729

Commits on Nov 8, 2023

• removed route caching

  akhumphrey

  committed
  3057041

  Copy full SHA for 3057041

• fixed coding standards issues

  akhumphrey

  committed
  c142352

  Copy full SHA for c142352

• re-fixed more coding standards issues

  akhumphrey

  committed
  3303581

  Copy full SHA for 3303581

Commits on Nov 17, 2023

• Fix: avoid creating dynamic property $options in sfViewCacheManager (FriendsOfSymfony1#290)

  Show description for 3c59273
  vimar

  authored
  3c59273

  Copy full SHA for 3c59273

• Update(github) Update github workflows, include cache for composer install

  thePanz

  committed
  ef9f881

  Copy full SHA for ef9f881

• Fix(php-cs-fixer) Fix php-cs-fixer warnings, according to new checks

  thePanz

  committed
  2826410

  Copy full SHA for 2826410

Commits on Dec 18, 2023

• add php8.3

  

  connorhu

  authored and

  thePanz

  committed
  8ba3ff2

  Copy full SHA for 8ba3ff2

• Fix(php-cs-fix) fix php-cs-fix single_space_around_construct warning

  

  connorhu

  authored and

  thePanz

  committed
  2a68033

  Copy full SHA for 2a68033

Commits on Dec 30, 2023

• Fix(php-cs-fixer) Fix php-cs-fixer to v3.45 and apply code fixes

  thePanz

  committed
  21c70f1

  Copy full SHA for 21c70f1

• Fix(deprecation) preg_match_all requires string parameter (FriendsOfSymfony1#298)

  iricketson

  authored
  1fe8979

  Copy full SHA for 1fe8979

Commits on Jan 3, 2024

• Merged remote tracking branch 'upstream/master' into integration

  akhumphrey

  committed
  d9e2763

  Copy full SHA for d9e2763

• Fix APC cache tests

  Show description for be784fc
  

  mentalstring

  authored and

  thePanz

  committed
  be784fc

  Copy full SHA for be784fc

• Add APCu support

  Show description for 1d14219
  

  mentalstring

  authored and

  thePanz

  committed
  1d14219

  Copy full SHA for 1d14219

• Fix sfCacheSessionStorageTest with PHP>=7.2

  Show description for 5615daa
  

  mentalstring

  authored and

  thePanz

  committed
  5615daa

  Copy full SHA for 5615daa

• Remove test dependency on APC

  Show description for 5837057
  

  mentalstring

  authored and

  thePanz

  committed
  5837057

  Copy full SHA for 5837057

• Fix deprecation on stropos() usage on sfDebug::shortenFilePath (FriendsOfSymfony1#299)

  Show description for 1446798
  iricketson

  authored
  1446798

  Copy full SHA for 1446798

• Fix strpos() deprecation on sfCacheSessionStorage check for cookie

  thePanz

  committed
  57758f5

  Copy full SHA for 57758f5

• Fix setrawcookie() deprecation on null parameter (FriendsOfSymfony1#304)

  thePanz

  authored
  d1dc877

  Copy full SHA for d1dc877

• Fix str_replace() deprecated null parameter on sfNumberFormat

  thePanz

  committed
  6edd425

  Copy full SHA for 6edd425

Commits on Jan 11, 2024

• Declare $params var

  iricketson

  committed
  806ce84

  Copy full SHA for 806ce84

• Replace default with 0

  iricketson

  committed
  d60c2c1

  Copy full SHA for d60c2c1

• Merged remote tracking branch 'upstream' into integration

  akhumphrey

  committed
  d9c21af

  Copy full SHA for d9c21af

• removed some automated testing for old php versions

  akhumphrey

  committed
  64be8ed

  Copy full SHA for 64be8ed

• updated php-cs-fixer config

  akhumphrey

  committed
  0a2daf4

  Copy full SHA for 0a2daf4

Commits on Jan 14, 2024

• Merge pull request FriendsOfSymfony1#307 from iricketson/fix/sfValidatorIp

  Show description for d0f559c
  connorhu

  authored
  d0f559c

  Copy full SHA for d0f559c

• Merge branch 'master' into fix/sfDoctrineFormGenerator

  connorhu

  authored
  f19a707

  Copy full SHA for f19a707

• Merge pull request FriendsOfSymfony1#306 from iricketson/fix/sfDoctrineFormGenerator

  Show description for abdbd74
  connorhu

  authored
  abdbd74

  Copy full SHA for abdbd74

Commits on Jan 17, 2024

• Update README

  Show description for 66e79cf
  

  mentalstring

  authored and

  thePanz

  committed
  66e79cf

  Copy full SHA for 66e79cf

• Fix link to GitHub pipeline badge

  thePanz

  authored
  424ed4d

  Copy full SHA for 424ed4d

• fix(config) sfCacheConfigHandler: There is no fourth argument. Nice catch phpstan!

  

  connorhu

  authored and

  thePanz

  committed
  9d26d67

  Copy full SHA for 9d26d67

• Fix PHP8.1 sfForm - Unsupported operand types: array + null on sfForm::updateValues()

  Show description for b88d698
  

  Tybaze

  authored and

  thePanz

  committed
  b88d698

  Copy full SHA for b88d698

Commits on Jan 18, 2024

• Merge branch 'master' into fix-link-to-github-pipeline-badge

  connorhu

  authored
  2a15114

  Copy full SHA for 2a15114

• Merge pull request FriendsOfSymfony1#311 from FriendsOfSymfony1/fix-link-to-github-pipeline-badge

  Show description for d90dc72
  connorhu

  authored
  d90dc72

  Copy full SHA for d90dc72

• fix(phpdoc) remove html code from throws phpdoc. phpstan don't like this

  

  connorhu

  authored and

  thePanz

  committed
  e6e9f94

  Copy full SHA for e6e9f94

Commits on Jan 19, 2024

• fix(phpdoc) remove version tag

  

  connorhu

  authored and

  thePanz

  committed
  6354fd3

  Copy full SHA for 6354fd3

Commits on Feb 2, 2024

• Merged remote tracking branch 'upstream' into integration

  akhumphrey

  committed
  38e21c2

  Copy full SHA for 38e21c2

• applied php-cs-fixer

  akhumphrey

  committed
  b167cb9

  Copy full SHA for b167cb9

• added missing properties

  akhumphrey

  committed
  bfeea0b

  Copy full SHA for bfeea0b

Commits on Feb 7, 2024

• PHP 8.3 deprecated errors fixed (FriendsOfSymfony1#320)

  

  miamibc

  authored and

  thePanz

  committed
  55a02ab

  Copy full SHA for 55a02ab

Commits on Feb 16, 2024

• Update min PHP requirement to v7.4 or v8.1

  thePanz

  committed
  eca1c5a

  Copy full SHA for eca1c5a

• Remove PHP v8.0 from CI workflow

  thePanz

  committed
  8bc7519

  Copy full SHA for 8bc7519

Commits on Feb 20, 2024

• Updated gh workflow to use latest actions

  

  thirsch

  authored and

  thePanz

  committed
  81205f6

  Copy full SHA for 81205f6

• Backported display_errors-handling to sf1

  

  thirsch

  authored and

  thePanz

  committed
  1b79957

  Copy full SHA for 1b79957

Commits on Feb 27, 2024

• Merged remote tracking branch upstream/master into integration

  akhumphrey

  committed
  5d62a2e

  Copy full SHA for 5d62a2e

• removed duplicate class properties

  akhumphrey

  committed
  a4c138b

  Copy full SHA for a4c138b

• Set min versions of swiftmailer to 5.4.13 and 6.2.5 and updated swiftmailer submodule (FriendsOfSymfony1#331)

  Show description for edb850f
  thirsch

  authored
  edb850f

  Copy full SHA for edb850f

Commits on Mar 13, 2024

• Sync changelog with latest releases (FriendsOfSymfony1#337)

  Show description for 146806f
  thePanz

  authored
  146806f

  Copy full SHA for 146806f

Commits on Mar 14, 2024

• Remove(legacy): Remove unsupported PHP docker images

  thePanz

  committed
  b74c8d7

  Copy full SHA for b74c8d7

• Remove(legacy): drop sfAPCCache cache as apc extension does not exist anymore

  Show description for c40ce1e
  thePanz

  committed
  c40ce1e

  Copy full SHA for c40ce1e

• Fix(docblock): fix typo in check_configuration.php docblock

  thePanz

  committed
  a810c4d

  Copy full SHA for a810c4d

• Update(check-config): use PHP constant for version check on check_configuration.php file

  thePanz

  committed
  f1df8ba

  Copy full SHA for f1df8ba

• Remove(legacy): delete checks for 'magic_quotes_gpc' and 'register_globals' ini settings, as removed on PHP v5.4

  thePanz

  committed
  e47ec1d

  Copy full SHA for e47ec1d

• Remove(legacy): delete EAccelerator cache, the extension is not existing for php v7.4

  Show description for 04ec0aa
  thePanz

  committed
  04ec0aa

  Copy full SHA for 04ec0aa

• Remove(legacy): drop XCache support, as the extension is not available for PHP >= 7.4

  thePanz

  committed
  019e25d

  Copy full SHA for 019e25d

• Remove(legacy): delete check for PHP < 5.2 in tests for mime_content_type bug

  thePanz

  committed
  2b5a586

  Copy full SHA for 2b5a586

• Remove(legacy): drop PHP v5.3 check for SQLite version match

  thePanz

  committed
  4cab155

  Copy full SHA for 4cab155

• Remove(legacy): drop PHP v5.4 check and compatibility layer on sfWebRequest

  thePanz

  committed
  64d9fc0

  Copy full SHA for 64d9fc0

• Remove(legacy): drop PHP v5.3 check on sfRoute

  Show description for 30a2fc5
  thePanz

  committed
  30a2fc5

  Copy full SHA for 30a2fc5

Commits on Mar 18, 2024

• Update: Update php-cs-fixer to v3.51

  Show description for ccbef01
  thePanz

  committed
  ccbef01

  Copy full SHA for ccbef01

• Update: php-cs-fixer, enable short array syntax

  thePanz

  committed
  53a2b12

  Copy full SHA for 53a2b12

• Update: move php-cs-fixer cache under .cache folder

  thePanz

  committed
  f0ba28d

  Copy full SHA for f0ba28d

• Update: run php-cs-fixer on PHP v7.4 as min supported version

  thePanz

  committed
  4d8148a

  Copy full SHA for 4d8148a

• Update: GitHub actions to run php-cs-fixer only on relevant changed files

  thePanz

  committed
  50a898b

  Copy full SHA for 50a898b

Commits on Mar 19, 2024

• Hotfix: Add type checking for deserialized data in sfParameterHolder and sfNamespacedParameterHolder (CVE-2024-28861)

  

  darkpills

  authored and

  thePanz

  committed
  0bd9d59

  Copy full SHA for 0bd9d59

• Update php-cs-fixer to v3.52

  thePanz

  committed
  50c946b

  Copy full SHA for 50c946b

Commits on Mar 21, 2024

• Remove(legacy): drop sf*Cache implementations for APC, XCache and EAccelerator extensions

  thePanz

  committed
  c1b411f

  Copy full SHA for c1b411f

• Phpstan: fix warnings on sfAPCiCache implementation, add docblocks and returns

  thePanz

  committed
  b9aa8ca

  Copy full SHA for b9aa8ca

• Phpstan: fix warnings on sfFileCache and sfMemcache implementation, add missing returns

  thePanz

  committed
  70aa655

  Copy full SHA for 70aa655

• Phpstan: fix missing sfTask* return statement

  thePanz

  committed
  1844457

  Copy full SHA for 1844457

• [widget] fix return statement missing (FriendsOfSymfony1#349)

  connorhu

  authored
  c2ea16d

  Copy full SHA for c2ea16d

• [validator] fix return statement missing (FriendsOfSymfony1#352)

  connorhu

  authored
  ddc1528

  Copy full SHA for ddc1528

• [view] fix return statement missing on ParamHolder and CacheManager (FriendsOfSymfony1#350)

  connorhu

  authored
  d86803d

  Copy full SHA for d86803d

• [task] Fix return statement missing on some tasks (FriendsOfSymfony1#353)

  connorhu

  authored
  7ddc3d1

  Copy full SHA for 7ddc3d1

• [util] fix missing return statement and docblock on sfContext class (FriendsOfSymfony1#351)

  connorhu

  authored
  8b68ee8

  Copy full SHA for 8b68ee8

Commits on Mar 27, 2024

• Merged remote tracking branch 'upstream' into integration

  akhumphrey

  committed
  772db3c

  Copy full SHA for 772db3c

• applied upstream php-cs-fixer configuration

  akhumphrey

  committed
  970a325

  Copy full SHA for 970a325

• corrected json format

  akhumphrey

  committed
  b48ebbd

  Copy full SHA for b48ebbd

• use php8.2 when linting

  akhumphrey

  committed
  793e466

  Copy full SHA for 793e466

• don't build php8.1

  akhumphrey

  committed
  4389e44

  Copy full SHA for 4389e44

• reverted many changes back to upstream equivalents

  akhumphrey

  committed
  ade9503

  Copy full SHA for ade9503

Commits on Mar 28, 2024

• removed upstream submodule

  akhumphrey

  committed
  44a6f52

  Copy full SHA for 44a6f52

• replaced submodule with our fork

  akhumphrey

  committed
  f3d14d0

  Copy full SHA for f3d14d0

• updated tests to match custom functionality

  akhumphrey

  committed
  10afc80

  Copy full SHA for 10afc80

• only test php82

  akhumphrey

  committed
  438b327

  Copy full SHA for 438b327

• corrected number of expected tests

  akhumphrey

  committed
  fea21bc

  Copy full SHA for fea21bc

• only use php8.2 for github actions

  akhumphrey

  committed
  22cdd1e

  Copy full SHA for 22cdd1e

• explicitly apply nullable_type_declaration_for_default_null_value

  akhumphrey

  committed
  b17808f

  Copy full SHA for b17808f

• attributes don't use \

  akhumphrey

  committed
  dec9025

  Copy full SHA for dec9025

• corrected method signatures

  akhumphrey

  committed
  2185c0d

  Copy full SHA for 2185c0d