Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null reference ex on Group.Expand #6

Closed
GoToNightmare opened this issue Sep 7, 2022 · 2 comments
Closed

Null reference ex on Group.Expand #6

GoToNightmare opened this issue Sep 7, 2022 · 2 comments
Labels
released on @mirror released

Comments

@GoToNightmare
Copy link
Contributor

When unchecking "Group Messages" in profiler (bottom left on image), Group.Expand throwing NullReferenceException bcs Head is null.
image
image

Mirage.Profiler/Assets/Mirage.Profiler/Editor/Messages/Group.cs

Line 59 in aea03ac

Head.SetText(_columns.Expand, Expanded ? "-" : "+");

Trace:

NullReferenceException: Object reference not set to an instance of an object
Mirage.NetworkProfiler.ModuleGUI.Messages.Group.Expand (System.Boolean expanded) (at Assets/Mirage.Profiler/Editor/Messages/Group.cs:59)
Mirage.NetworkProfiler.ModuleGUI.Messages.MessageView.DrawGroups (System.Boolean withHeader) (at Assets/Mirage.Profiler/Editor/Messages/MessageView.cs:81)
Mirage.NetworkProfiler.ModuleGUI.Messages.MessageView.Draw (System.Collections.Generic.IEnumerable`1[T] frames, System.Boolean groupMessages) (at Assets/Mirage.Profiler/Editor/Messages/MessageView.cs:32)
Mirage.NetworkProfiler.ModuleGUI.Messages.MessageViewController.ReloadMessages () (at Assets/Mirage.Profiler/Editor/Messages/MessageViewController.cs:203)
Mirage.NetworkProfiler.ModuleGUI.Messages.MessageViewController.ReloadData () (at Assets/Mirage.Profiler/Editor/Messages/MessageViewController.cs:166)
Mirage.NetworkProfiler.ModuleGUI.Messages.MessageViewController.<CreateViewInternal>b__13_0 (UnityEngine.UIElements.ChangeEvent`1[T] _) (at Assets/Mirage.Profiler/Editor/Messages/MessageViewController.cs:91)
UnityEngine.UIElements.EventCallbackFunctor`1[TEventType].Invoke (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.PropagationPhase propagationPhase) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/Events/EventCallback.cs:79)
UnityEngine.UIElements.EventCallbackRegistry.InvokeCallbacks (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.PropagationPhase propagationPhase) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/Events/EventCallbackRegistry.cs:353)
UnityEngine.UIElements.CallbackEventHandler.HandleEvent (UnityEngine.UIElements.EventBase evt) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/Events/EventHandler.cs:186)
UnityEngine.UIElements.EventDispatchUtilities.PropagateEvent (UnityEngine.UIElements.EventBase evt) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/Events/IEventDispatchingStrategy.cs:113)
UnityEngine.UIElements.DefaultDispatchingStrategy.DispatchEvent (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/Events/DefaultDispatchingStrategy.cs:15)
UnityEngine.UIElements.EventDispatcher.ApplyDispatchingStrategies (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel, System.Boolean imguiEventIsInitiallyUsed) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:381)
UnityEngine.UIElements.EventDispatcher.ProcessEvent (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:344)
UnityEngine.UIElements.EventDispatcher.ProcessEventQueue () (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:306)
UnityEngine.UIElements.EventDispatcher.OpenGate () (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:270)
UnityEngine.UIElements.EventDispatcherGate.Dispose () (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:75)
UnityEngine.UIElements.EventDispatcher.ProcessEvent (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:372)
UnityEngine.UIElements.EventDispatcher.ProcessEventQueue () (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:306)
UnityEngine.UIElements.EventDispatcher.OpenGate () (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:270)
UnityEngine.UIElements.EventDispatcherGate.Dispose () (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:75)
UnityEngine.UIElements.EventDispatcher.ProcessEvent (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:372)
UnityEngine.UIElements.EventDispatcher.Dispatch (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel, UnityEngine.UIElements.DispatchMode dispatchMode) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/EventDispatcher.cs:222)
UnityEngine.UIElements.BaseVisualElementPanel.SendEvent (UnityEngine.UIElements.EventBase e, UnityEngine.UIElements.DispatchMode dispatchMode) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/Panel.cs:419)
UnityEngine.UIElements.UIElementsUtility.DoDispatch (UnityEngine.UIElements.BaseVisualElementPanel panel) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/UIElementsUtility.cs:468)
UnityEngine.UIElements.UIElementsUtility.UnityEngine.UIElements.IUIElementsUtility.ProcessEvent (System.Int32 instanceID, System.IntPtr nativeEventPtr, System.Boolean& eventHandled) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/UIElementsUtility.cs:211)
UnityEngine.UIElements.UIEventRegistration.ProcessEvent (System.Int32 instanceID, System.IntPtr nativeEventPtr) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/UIElementsUtility.cs:74)
UnityEngine.UIElements.UIEventRegistration+<>c.<.cctor>b__1_2 (System.Int32 i, System.IntPtr ptr) (at /Users/bokken/buildslave/unity/build/ModuleOverrides/com.unity.ui/Core/UIElementsUtility.cs:28)
UnityEngine.GUIUtility.ProcessEvent (System.Int32 instanceID, System.IntPtr nativeEventPtr, System.Boolean& result) (at /Users/bokken/buildslave/unity/build/Modules/IMGUI/GUIUtility.cs:189)
@GoToNightmare GoToNightmare changed the title Null refernce ex on Group.Expand Null reference ex on Group.Expand Sep 7, 2022
github-actions bot pushed a commit that referenced this issue Sep 8, 2022
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
9340625 
# [1.1.0](v1.0.4...v1.1.0) (2022-09-08)

### Bug Fixes

* fixes null ref when sort header is null ([d233036](d233036)), closes [#4](#4)
* fixing header being squashed if vertical scroll is full ([ad29f2e](ad29f2e))
* fixing null ref when group message is false ([004ba4e](004ba4e)), closes [#6](#6)
* stopping exception if rpc name does not contain dot ([#3](#3)) ([324a374](324a374))

### Features

* adding group message to save data ([3061381](3061381))
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

James-Frowen added a commit that referenced this issue Sep 8, 2022
@James-Frowen
fix: fixing null ref when group message is false
6d3dfbf 
fixes #6
github-actions bot pushed a commit that referenced this issue Sep 8, 2022
@semantic-release-bot
chore(release): 1.1.0-mirror.8 [skip ci]
e5b09b8 
# [1.1.0-mirror.8](v1.1.0-mirror.7...v1.1.0-mirror.8) (2022-09-08)

### Bug Fixes

* fixes null ref when sort header is null ([9848b81](9848b81)), closes [#4](#4)
* fixing header being squashed if vertical scroll is full ([89e651e](89e651e))
* fixing null ref when group message is false ([6d3dfbf](6d3dfbf)), closes [#6](#6)
* stopping exception if rpc name does not contain dot ([#3](#3)) ([4f7a1bd](4f7a1bd))

### Features

* adding group message to save data ([12c3313](12c3313))
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

🎉 This issue has been resolved in version 1.1.0-mirror.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @mirror released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoToNightmare