Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To display the error message #120

Merged
merged 1 commit into from
Jul 13, 2018
Merged

To display the error message #120

merged 1 commit into from
Jul 13, 2018

Conversation

lvscar
Copy link
Contributor

@lvscar lvscar commented Jul 13, 2018

I think logging these critical failure and displaying in terminal will be helpful for Jaguar user.

@lvscar lvscar mentioned this pull request Jul 13, 2018
Closed
@tejainece tejainece self-requested a review July 13, 2018 16:53
tejainece
tejainece approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@tejainece tejainece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejainece
Copy link
Member

Thanks for the pull request!

There are plans to add better logging infrastructure to Jaguar. The issue can be tracked here: #121

@tejainece tejainece merged commit cd1733b into Jaguar-dart:master Jul 13, 2018
@lvscar
Copy link
Contributor Author

lvscar commented Jul 13, 2018

Cheer~

I hope I can contribute more on the Jaguar project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejainece tejainece tejainece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lvscar @tejainece