Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) #2 Adds pop-up asking for password at launch. #9

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

JacobTrossing
Copy link
Owner

Adds a pop-up at the start of the program which asks the user for the password if they have checked that they want to use a proxy with password.

JacobTrossing and others added 4 commits March 1, 2023 14:28
 Instead asks user for the password at the start of the program if they
 have enabled proxy with password.
…ered from JabRefGUI if proxy requires password
…hentication are enabled, before only auth was checked
@Darpos Darpos self-requested a review March 6, 2023 08:39
@Darpos Darpos self-assigned this Mar 6, 2023
@Minhao037 Minhao037 self-requested a review March 6, 2023 08:41
@JacobTrossing JacobTrossing changed the title Add #2 (feat) #2 Adds pop-up asking for password at launch. Mar 6, 2023
Copy link
Collaborator

@Minhao037 Minhao037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Darpos Darpos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and looks good! Nice :)

@Darpos Darpos merged commit e4d4f45 into fix-for-issue-8055 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants