Remove obsolete ActiveIssue attributes for dotnet#23972 (dotnet#39842)

Jacksondr5 · Aug 10, 2020 · a2e8805 · a2e8805
1 parent c49ebd6
commit a2e8805
Show file tree

Hide file tree

Showing 33 changed files with 32 additions and 217 deletions.
diff --git a/.../System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionHostTests.cs b/.../System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionHostTests.cs
@@ -10,7 +10,6 @@ namespace System.Composition.Hosting.Core.Tests
     public class CompositionHostTests
     {
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetExport_CompositionContextContract_ReturnsExpected()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -21,7 +20,6 @@ public void GetExport_CompositionContextContract_ReturnsExpected()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetExport_MultipleDependencies_ReturnsExpected()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new MultipleDependency()))
@@ -56,7 +54,6 @@ public override IEnumerable<ExportDescriptorPromise> GetExportDescriptors(Compos
         }
 
         [Theory]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         [InlineData(typeof(int), new Type[] { typeof(int) })]
         [InlineData(typeof(IList<>), new Type[] { typeof(IList<>) })]
         [InlineData(typeof(ICollection<>), new Type[] { typeof(ICollection<>) })]
@@ -86,7 +83,6 @@ public void GetExport_LazyOrExportFactoryContractType_ReturnsExpected(Type type,
         }
 
         [Theory]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         [InlineData(typeof(string[]), new Type[] { typeof(string[]), typeof(string) })]
         [InlineData(typeof(IList<string>), new Type[] { typeof(IList<string>), typeof(string) })]
         [InlineData(typeof(ICollection<string>), new Type[] { typeof(ICollection<string>), typeof(string) })]
@@ -105,7 +101,6 @@ public void GetExport_ImoportManyWithMetadataConstraints_ReturnsExpected(Type co
         }
 
         [Theory]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         [InlineData(typeof(ExportFactory<int>), null, new Type[] { typeof(int), typeof(ExportFactory<int>) })]
         [InlineData(typeof(ExportFactory<int>), new string[] { "1", "2", "3" }, new Type[] { typeof(int), typeof(ExportFactory<int>) })]
         [InlineData(typeof(ExportFactory<int, ParameterlessConstructor>), null, new Type[] { typeof(int), typeof(ExportFactory<int, ParameterlessConstructor>) })]
@@ -134,7 +129,6 @@ public override IEnumerable<ExportDescriptorPromise> GetExportDescriptors(Compos
         }
 
         [Theory]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         [InlineData(typeof(Lazy<int, int>))]
         [InlineData(typeof(Lazy<int, IDictionary<string, string>>))]
         [InlineData(typeof(Lazy<int, PrivateConstructor>))]
@@ -148,7 +142,6 @@ public void GetExport_InvalidMetadata_ThrowsComposititionFailedException(Type ty
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetExport_AbstractMetadata_ThrowsInvalidOperationException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -158,7 +151,6 @@ public void GetExport_AbstractMetadata_ThrowsInvalidOperationException()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetExport_NullProviderInProviders_ThrowsNullReferenceException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[] { null }))
@@ -177,7 +169,6 @@ public void TryGetExport_NullContract_ThrowsArgumentNullException()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetExport_MultipleReturns_ThrowsCompositionFailedException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new MultiplePromises()))
@@ -200,7 +191,6 @@ public override IEnumerable<ExportDescriptorPromise> GetExportDescriptors(Compos
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetExport_FailedDependency_ThrowsCompositionFailedException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new FailedDependency()))

diff --git a/...em.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionOperationTests.cs b/...em.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionOperationTests.cs
@@ -9,7 +9,6 @@ namespace System.Composition.Hosting.Core.Tests
     public class CompositionOperationTests
     {
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void Run_ValidContextAndAction_ReturnsExpected()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -49,7 +48,6 @@ public void Run_NullOutmostContext_ThrowsArgumentNullException()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void Run_NullActivator_ThrowsArgumentNullException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -62,7 +60,6 @@ public void Run_NullActivator_ThrowsArgumentNullException()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void AddNonPrequisiteAction_NullAction_ThrowsArgumentNullException()
         {
             object Activator(LifetimeContext context, CompositionOperation operation)
@@ -81,7 +78,6 @@ object Activator(LifetimeContext context, CompositionOperation operation)
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void AddPostCompositionAction_NullAction_ThrowsArgumentNullException()
         {
             object Activator(LifetimeContext context, CompositionOperation operation)

diff --git a/.../System.Composition.Hosting/tests/System/Composition/Hosting/Core/LifetimeContextTests.cs b/.../System.Composition.Hosting/tests/System/Composition/Hosting/Core/LifetimeContextTests.cs
@@ -14,7 +14,6 @@ public void AllocateSharingId_InvokeMultipleTimes_ReturnsDifferentValue()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void AddBoundInstance_NonNullInstance_DisposesInstanceOnDisposal()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -35,7 +34,6 @@ public void AddBoundInstance_NonNullInstance_DisposesInstanceOnDisposal()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void AddBoundInstance_NullInstance_ThrowsNullReferenceExceptionOnDisposal()
         {
             CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]);
@@ -47,7 +45,6 @@ public void AddBoundInstance_NullInstance_ThrowsNullReferenceExceptionOnDisposal
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void AddBoundInstance_Disposed_ThrowsObjectDisposedException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -61,7 +58,6 @@ public void AddBoundInstance_Disposed_ThrowsObjectDisposedException()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetOrCreate_ValidActivatorDuringInitialization_Success()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -90,7 +86,6 @@ object GetOrCreateActivate(LifetimeContext getOrCreateContext, CompositionOperat
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetOrCreate_ValidActivatorAfterInitialization_Success()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -120,7 +115,6 @@ object Activator(LifetimeContext activatorContext, CompositionOperation activato
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetOrCreate_NullActivator_ThrowsNullReferenceException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -139,7 +133,6 @@ object Activator(LifetimeContext activatorContext, CompositionOperation activato
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void GetOrCreate_NullOperation_ThrowsNullReferenceException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -152,7 +145,6 @@ public void GetOrCreate_NullOperation_ThrowsNullReferenceException()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void FindContextWithin_NullSharingBoundary_ReturnsRoot()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -165,7 +157,6 @@ public void FindContextWithin_NullSharingBoundary_ReturnsRoot()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void FindContextWithin_UnknownSharingBoundary_ThrowsCompositionFailedException()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))
@@ -178,7 +169,6 @@ public void FindContextWithin_UnknownSharingBoundary_ThrowsCompositionFailedExce
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void ToString_NoParent_ReturnsExpected()
         {
             using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0]))

diff --git a/src/libraries/System.Composition.TypedParts/tests/ContainerConfigurationTests.cs b/src/libraries/System.Composition.TypedParts/tests/ContainerConfigurationTests.cs
@@ -15,7 +15,6 @@ namespace System.Composition.Hosting.Tests
     public class ContainerConfigurationTests
     {
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void WithProvider_ValidProvider_RegistersProvider()
         {
             var configuration = new ContainerConfiguration();
@@ -62,7 +61,6 @@ public void WithProvider_NullProvider_ThrowsArgumentNullException()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void WithDefaultConventions_PartWithNoMatchingConvention_Success()
         {
             var conventions = new ConventionBuilder();
@@ -77,7 +75,6 @@ public void WithDefaultConventions_PartWithNoMatchingConvention_Success()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void WithDefaultConventions_IEnumerablePartsWithNoMatchingConvention_Success()
         {
             var conventions = new ConventionBuilder();
@@ -92,7 +89,6 @@ public void WithDefaultConventions_IEnumerablePartsWithNoMatchingConvention_Succ
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void WithDefaultConventions_PartsArrayWithNoMatchingConvention_Success()
         {
             var conventions = new ConventionBuilder();
@@ -107,7 +103,6 @@ public void WithDefaultConventions_PartsArrayWithNoMatchingConvention_Success()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void WithDefaultConventions_PartTNoMatchingConvention_Success()
         {
             var conventions = new ConventionBuilder();
@@ -143,7 +138,6 @@ public void WithDefaultConventions_AlreadyHasDefaultConventions_ThrowsInvalidOpe
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void WithPartT_Convention_Success()
         {
             var conventions = new ConventionBuilder();
@@ -157,7 +151,6 @@ public void WithPartT_Convention_Success()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void WithPart_Convention_Success()
         {
             var conventions = new ConventionBuilder();
@@ -179,7 +172,6 @@ public void WithPart_NullPartType_ThrowsArgumentNullException()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void WithParts_Convention_Success()
         {
             var conventions = new ConventionBuilder();
@@ -262,7 +254,6 @@ public void WithAssemby_Null_ThrowsNullReferenceExceptionOnCreation()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_ExportedSubClass_Success()
         {
             CompositionHost container = new ContainerConfiguration()
@@ -283,7 +274,6 @@ public class Base
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_OpenGenericTypes_Success()
         {
             var conventions = new ConventionBuilder();
@@ -313,7 +303,6 @@ public EFRepository(IContainer test) { }
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_ImportConventionsWithInheritedProperties_Success()
         {
             var conventions = new ConventionBuilder();
@@ -341,7 +330,6 @@ public class BaseWithImport
         public class DerivedFromBaseWithImport : BaseWithImport { }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_ExportConventionsWithInheritedProperties_Success()
         {
             var conventions = new ConventionBuilder();
@@ -363,7 +351,6 @@ public class BaseWithExport
         public class DerivedFromBaseWithExport : BaseWithExport { }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_ExportsToInheritedProperties_DontInterfereWithBase()
         {
             var conventions = new ConventionBuilder();
@@ -387,7 +374,6 @@ public class BaseWithExport2
         public class DerivedFromBaseWithExport2 : BaseWithExport { }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_HasConventions_ClassExportsAreNotInherited()
         {
             CompositionHost container = new ContainerConfiguration()
@@ -397,7 +383,6 @@ public void CreateContainer_HasConventions_ClassExportsAreNotInherited()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_HasConventions_PropertyExportsAreNotInherited()
         {
             CompositionHost container = new ContainerConfiguration()
@@ -420,7 +405,6 @@ public class DerivedFromBaseWithDeclaredExports : BaseWithDeclaredExports { }
         public class CustomExport : ExportAttribute { }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_HasConventions_CustomAttributesAreNotInherited()
         {
             CompositionHost container = new ContainerConfiguration()
@@ -435,7 +419,6 @@ public class BaseWithCustomExport { }
         public class DerivedFromBaseWithCustomExport : BaseWithCustomExport { }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_OpenGenericTypePart_Success()
         {
             ContainerConfiguration configuration = new ContainerConfiguration().WithParts(typeof(GenericExportedType<>));
@@ -489,7 +472,6 @@ public void CreateContainer_UnassignableType_ThrowsCompositionFailedException()
         public class ContractExportedType { }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_AbstractOrStructType_Success()
         {
             ContainerConfiguration configuration = new ContainerConfiguration().WithParts(typeof(AbstractClass), typeof(StructType));
@@ -503,7 +485,6 @@ public abstract class AbstractClass { }
         public struct StructType { }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_MetadataProperty_Success()
         {
             ContainerConfiguration configuration = new ContainerConfiguration().WithPart(typeof(MetadataProperty));
@@ -541,7 +522,6 @@ public class MetadataProperty
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void CreateContainer_MetadataClass_Success()
         {
             ContainerConfiguration configuration = new ContainerConfiguration().WithPart(typeof(MetadataClass));

diff --git a/src/libraries/System.Composition.TypedParts/tests/ReflectionTests.cs b/src/libraries/System.Composition.TypedParts/tests/ReflectionTests.cs
@@ -27,7 +27,6 @@ public class ReflectionTests
         /// revert to a default value during GetExport.
         /// </remarks>
         [ConditionalFact(nameof(HasMultiplerProcessors))]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void MultiThreadedGetExportsWorkWithImportingConstuctor()
         {
             var errors = new ConcurrentBag<Exception>();

diff --git a/src/libraries/System.Composition/tests/ActivationEventOrderingTests.cs b/src/libraries/System.Composition/tests/ActivationEventOrderingTests.cs
@@ -31,7 +31,6 @@ public void OnImportsSatisfied()
     public class ActivationEventOrderingTests : ContainerTests
     {
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void OnImportsSatisfiedIsCalledAfterPropertyInjection()
         {
             var cc = CreateContainer(typeof(TracksImportSatisfaction), typeof(Imported));

diff --git a/src/libraries/System.Composition/tests/CardinalityTests.cs b/src/libraries/System.Composition/tests/CardinalityTests.cs
@@ -31,7 +31,6 @@ public UsesLog(ILog log) { }
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void RequestingOneWhereMultipleArePresentFails()
         {
             var c = CreateContainer(typeof(LogA), typeof(LogB));
@@ -42,7 +41,6 @@ public void RequestingOneWhereMultipleArePresentFails()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/23972", TargetFrameworkMonikers.NetFramework)]
         public void ImportingOneWhereMultipleArePresentFails()
         {
             var c = CreateContainer(typeof(LogA), typeof(LogB), typeof(UsesLog));