Fix some errors #209
Fix some errors #209
Conversation
| @@ -10731,6 +10733,7 @@ | |||
| 𣛘 dhhk | |||
| 柳 dhhl | |||
| 櫛 dhhl | |||
| 𬂪 dhhl | |||
There was a problem hiding this comment.
When a duplicate mapping (e.g. both 柳 amd 𬂪 map to dhhl), the new mapping will be placed under current mappings since they are rare characters.
Cangjie5.txt
Outdated
| @@ -59337,6 +59336,7 @@ | |||
| 隮 nlyx | |||
| 𮥱 nlyxf | |||
| 𨼻 nlyxv | |||
| 𨽘 nlyxv | |||
There was a problem hiding this comment.
It was hyxv before this PR, @Jackchows please double check if nlyxv is correct.
Cangjie5.txt
Outdated
| @@ -58867,6 +58864,7 @@ | |||
| 䧑 nljmo | |||
| 院 nljmu | |||
| 𨺋 nljnu | |||
| 𨺶 nljoe | |||
There was a problem hiding this comment.
It was mnjoe before this PR, @Jackchows please double check if nljoe is correct, thanks!
Cangjie5.txt
Outdated
| @@ -103968,6 +103967,7 @@ | |||
| 烲 xqlf | |||
| 𰓐 xqlk | |||
| 𫑢 xqll | |||
| 𪮋 xqll | |||
There was a problem hiding this comment.
I am not sure how should we deal with duplicate mappings which begin with x, are they supposed to be unique?
There was a problem hiding this comment.
Yes, we keep only one and remove others.
There was a problem hiding this comment.
Okay in this case I will remove xqll for 𪮋.
|
@Jackchows Review comments are addressed. |
Fixes #208
This PR should be reviewed commit by commit.
When merging this PR, consider use "Squash and Merge" so the git history will be consolidated to a single commit.
cc @Jackchows