Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refactoring RNS & gutting Stray Debris #381

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

TheMarstonConnell
Copy link
Member

Title says it all

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5017e28) 44.18% compared to head (bb801db) 44.13%.

Files Patch % Lines
x/rns/client/cli/tx_bid.go 0.00% 5 Missing ⚠️
x/rns/client/cli/tx_list.go 0.00% 5 Missing ⚠️
x/rns/types/message_bid.go 0.00% 1 Missing ⚠️
x/rns/types/message_list.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   44.18%   44.13%   -0.06%     
==========================================
  Files         230      229       -1     
  Lines        8579     8571       -8     
==========================================
- Hits         3791     3783       -8     
  Misses       4555     4555              
  Partials      233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@karnthis karnthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TheMarstonConnell TheMarstonConnell merged commit ebe2ead into master Nov 14, 2023
7 of 11 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/more-proto-fix branch November 14, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants