Added zooming and offset to collision #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added collision buffer distance, zoom to control distance with keys/mouse wheel, Some comments
Added Zoom and buffer controls to GUI
Increased Window height to 740 to allow GUI to be seen a TODO for later might be to make it a scrollContainer
Small typo.
Small typo.
Triggered check
When starting with a privot defined, and the camera in the wrong resultant position, the displayed result would remain incorrect until the first input event was received to properly define the _triggered boolean. By forcing an update after enabling the script before the first input event is required corrects this bug.
|
Hey, thanks for submitting this nice features and sorry for the late response. |
|
No worries and no rush :) Glad to contribute to a script I used for so long thanks for sharing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the script! I first used it back in 2018 and wanted to add some of the little things I did to it. If these changes are not wanted or are not implemented as well as could be I appologize for using your time.
I added the ability to use actions to change the distance by a percentage of the 'distance' variable value so you can scroll your mousewheel to zoom in and out of whatever your looking at.
Also added an easy to access offset to the ray trace collision position towards the privot to prevent visual clipping. That is to say when you collide with the box to help prevent seeing through the box when at an angle. I realize an offset to the position is probably not the best solution to the clipping but it worked well for most of my use cases, it was simple to implement, and not alot of overhead. The better solution might be to use additional rays to determine if you'd be clipping the object if the camera is at the position but I'm to tired to mess with rays.
Regardless of wether this ends up being useful or not hope you have a good one.
Edit: Readabilty hopefully.