Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default File Chooser to show supported files extensions #9812

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

morganteg
Copy link
Contributor

@morganteg morganteg commented Apr 27, 2023

Fixes #9372
Change default File Chooser to show supported files extensions

Compulsory checks

Preview Give feedback

Schermata del 2023-04-27 21-53-46

@calixtus calixtus changed the title Fixes #9372 Change default File Chooser to show supported files extensions Apr 27, 2023
@Siedlerchr
Copy link
Member

Can you please add a screenshot how it looks with a single extension and with multiple?
You also need to adjust the l10n english file
https://devdocs.jabref.org/code-howtos/localization.html

@morganteg morganteg force-pushed the fir-for-issue-9372 branch from d24797c to 3b72050 Compare April 28, 2023 13:15
@morganteg morganteg marked this pull request as ready for review April 28, 2023 13:44
@morganteg morganteg force-pushed the fir-for-issue-9372 branch from 3b72050 to 3f2045a Compare April 28, 2023 14:08
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Easy fix :). Small comments attached.

CHANGELOG.md Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/util/FileFilterConverter.java Outdated Show resolved Hide resolved
@morganteg morganteg force-pushed the fir-for-issue-9372 branch from 3f2045a to cb6106b Compare April 28, 2023 15:38
Change default File Chooser to show supported files extensions
@morganteg morganteg force-pushed the fir-for-issue-9372 branch from cb6106b to 02a5122 Compare April 28, 2023 15:40
@morganteg morganteg requested a review from koppor April 28, 2023 15:56
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 28, 2023
@Siedlerchr
Copy link
Member

Thanks for the fix! LGTM!
PS: You don't need to force push. When we merge, we have the option to squash all commits into one

@Siedlerchr Siedlerchr merged commit bf6e57c into JabRef:main Apr 28, 2023
@koppor
Copy link
Member

koppor commented Apr 28, 2023

Moreover, seeing the new commits eases the second review / check if the comments are adressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save/save as: file type shows BIBTEX_DB
3 participants