Observable Preferences V (SavePreferences) #9808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/jabref/logic/importer/fetcher/ArXivFetcherTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ArXivFetcherTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ArXivFetcherTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ArXivFetcherTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ArXivFetcherTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ArXivFetcherTest.java
Outdated
Show resolved
Hide resolved
Siedlerchr
changed the title
calixtus
added
status: ready-for-review
koppor
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Codewise, it looks good. Nitpick at the Changelog :p
However, we could have a performance issue on saving. At first time, I tried this, saving on my network drive took ages. Checking out main and then saving was fast. Going back to the PR: Saving was fast again. Thus, maybe not an issue of this PR, but I just wanted to note it down.
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
|
About speed: please try gradle clean and then run again. |
koppor
approved these changes
Apr 29, 2023
Tried it and no performance issues. Might have been a hackup at first try. |
Siedlerchr
approved these changes
Apr 30, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9619
Probably my worst one yet: 83 files changed. As the whole complex was tangled into itself parting it in multiple PRs was not reasonable. Again easiest to review PR by PR.
Moved one setting from file tab to general tab, as it is a behavioral one.
Changed the way of SavePreferences to SaveConfiguration, since i believe it was just a DTO.
Compulsory checks