Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BibTeXML support #9583

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Remove BibTeXML support #9583

merged 5 commits into from
Jan 30, 2023

Conversation

sreenath-tm
Copy link
Contributor

@sreenath-tm sreenath-tm commented Jan 28, 2023

This fixes #9540 where the importer and exporter for BibTexXML have been removed and the corresponding test classes also have been removed or modified accordingly.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Siedlerchr commented Jan 28, 2023

Looks good so far, please check also in the resources folder src/test/resources/logic for importer and exporter in the fileformat subfolder and remove them as well:

Please also add a changelog entry under Removed

e.g.:

grafik

@sreenath-tm
Copy link
Contributor Author

sreenath-tm commented Jan 29, 2023

All the files with BibTeXML prefix will not be useful now right. The files having prefix should be removed from both importer and exporter right.

@Siedlerchr
Copy link
Member

Yes, remove them please

@sreenath-tm
Copy link
Contributor Author

Hi, @Siedlerchr I have removed the BibTeXML-related resources from both the importer and exporter. The changes to the Changelog.md have also been done.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 30, 2023
@Siedlerchr Siedlerchr merged commit 0b9d629 into JabRef:main Jan 30, 2023
@Siedlerchr
Copy link
Member

Thanks again for your contribution and your ongoing interest in JabREf

@koppor koppor mentioned this pull request Mar 18, 2023
@koppor
Copy link
Member

koppor commented Mar 18, 2023

While investigating #9673, I learned that in the context of importer/exporter adjustment, maybe, build.gradle needs to be changed.

@sreenath-tm I needed to do a follow-up PR on this (#9684). There were some left-overs. Do you know the IntelliJ shortcut Ctrl+Shift+F? With that, one can search for all occurrences of text.

@sreenath-tm
Copy link
Contributor Author

Yes, @koppor I had removed all the occurrences that I could find. Sorry If I have missed anything.

@koppor
Copy link
Member

koppor commented Mar 19, 2023

No worries, just wanted to give the hint of full text search (which I also forget about know and then...). Looking forward for other contributions by you 🤩.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for BibTeXML
3 participants