Adding notifications when writing metadata to pdfs #8647
Conversation
Adding notifications when writing metadata to pdfs
|
Wow, this already looks pretty good. Definitely a step forward! Thank you! |
|
Please have a look at the faliing unit test regarding Localization, see also https://devdocs.jabref.org/getting-into-the-code/code-howtos#using-localization-correctly |
| } catch (IOException | TransformerException ex) { | ||
| // TODO: Print error message | ||
| // Localization.lang("Error while writing") + " '" + file.toString() + "': " + ex; | ||
| dialogService.notify(Localization.lang("Error while writing") + " '" + file.toString() + "': " + ex); |
There was a problem hiding this comment.
Please also log the message using LOGGER.error(...)
| } catch (IOException | TransformerException ex) { | ||
| // TODO: Print error message | ||
| // Localization.lang("Error while writing") + " '" + file.toString() + "': " + ex; | ||
| dialogService.notify(Localization.lang("Error while writing") + " '" + file.toString() + "': " + ex); |
There was a problem hiding this comment.
Instead of printing the exception in the notify, I would add instead: dialogService.notify(Localization.lang("Error while writing metadata. See the error log for details.")
|
I tested your current version. When I tried to write metadata to a write protected file the following error emerged:
Which is fine i guess. When i tried writing a normal file, "Finished writing metadata!". When the file was moved somewhere else "File not found" emerged. Looking good. Thumps up. |
|
Thanks for the follow up! Please have a look at the failing test |
Siedlerchr
added
the
status: ready-for-review
|
I took the opportunity to fix and slighly reword the localization. |
koppor
removed
the
status: ready-for-review
|
Thanks nontheless for your contribution @AntonioIgorCarvalho |
…-0.3.0' of github.com:JabRef/jabref into dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0 * 'dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0' of github.com:JabRef/jabref: try version 0.3.1 Save xmp data to new file and then copy it back (#8656) Adding notifications when writing metadata to pdfs (#8647)
Adding notifications when writing metadata to pdfs
Fixes #8276
Simple notifications added when clicking in this button specifically, as mentioned in issue #8276
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Screenshot with success:
Screenshot when writting in a deleted file:
Screenshot when writting in a corrupted file:
Error log when writting in a corrupted file:
