Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observable Preferences K (Integration of wild preferences) #8422

Merged
merged 9 commits into from
Jan 30, 2022
Merged

Observable Preferences K (Integration of wild preferences) #8422

merged 9 commits into from
Jan 30, 2022

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Jan 13, 2022 •
edited
Loading

Follow up to #8370

  • Integrated some loose preferences:
    • openLastEdited
    • autoSave
    • FileHistory (still a bug)
    • mergeDiffMode
    • lastSelectedIdBasedFetcher
    • warnAboutDuplicatesForImport
  • Extracted DiffMode to a separate class

.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus changed the title Observable Preferences K (ImportExport revisited, ...) Observable Preferences K (Integration of wild preferences) Jan 16, 2022
@calixtus calixtus added preferences type: code-quality Issues related to code or architecture decisions labels Jan 16, 2022
@calixtus calixtus marked this pull request as ready for review January 17, 2022 17:40
@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 17, 2022
@calixtus calixtus requested a review from koppor January 28, 2022 23:58
@Siedlerchr
Copy link
Member

Merging this now and hoping it doesn't break anything ;)

@Siedlerchr Siedlerchr merged commit 8ca6b7f into main Jan 30, 2022
@Siedlerchr Siedlerchr deleted the importexport-prefs branch January 30, 2022 19:15
@calixtus calixtus mentioned this pull request Aug 16, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@koppor koppor Awaiting requested review from koppor

Assignees
No one assigned
Labels
preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calixtus @Siedlerchr