Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated CustomizeExternalFileTypesDialog into Preferences #8341

Merged
merged 4 commits into from
Dec 20, 2021

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Dec 19, 2021

grafik

Instead of opening the dialog with a button inside the External programs tab in the preferences nested inside the Push to applications preferences, this dialog has now it's own tab in the preferences.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 19, 2021

Might check if this als fixes #5902

@calixtus
Copy link
Member Author

Probably not, as i only integrated the dialog in the preferences dialog, but i did not change anything on the table.

@calixtus
Copy link
Member Author

But this rather seems to be a javafx bug.

@Siedlerchr
Copy link
Member

Merge after 5.4 release due to l10n change

@calixtus calixtus added preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Dec 19, 2021
@Siedlerchr Siedlerchr merged commit c45d948 into main Dec 20, 2021
@Siedlerchr Siedlerchr deleted the externalfiletypes-prefs branch December 20, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants