Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make fields sorted by lexicographical order #7711

Merged
merged 13 commits into from
May 8, 2021
Merged

fix: make fields sorted by lexicographical order #7711

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
914ebdf
Merge pull request #2 from JabRef/main
dateri Apr 24, 2021
b768728
Merge pull request #3 from JabRef/main
dateri May 7, 2021
5af1cdf
fix: Random order of fields
dateri May 7, 2021
039152d
fix: Random order of fields
dateri May 7, 2021
95d3b9c
fix: Random order of fields
dateri May 7, 2021
9f82e30
fix: Random order of fields
dateri May 7, 2021
34880e6
fix: Random order of fields
dateri May 7, 2021
33da5f2
fix: change CHANGELOG.md
dateri May 7, 2021
743d007
modify code in ViewModel.
dateri May 7, 2021
a7ffb9b
Add a blank line for passing checkstyle.
dateri May 7, 2021
b6adbc4
Make code logic simpler.
dateri May 7, 2021
5e98e24
fix the order for import.
dateri May 7, 2021
0694347
fix: use sortedList
dateri May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We fixed an issue where the XMP Importer would incorrectly return an empty default entry when importing pdfs [#6577](https://github.com/JabRef/jabref/issues/6577)
- We fixed an issue where opening the menu 'Library properties' marked the library as modified [#6451](https://github.com/JabRef/jabref/issues/6451)
- We fixed an issue when importing resulted in an exception [#7343](https://github.com/JabRef/jabref/issues/7343)
- We fixed an issue where the field in the Field formatter dropdown selection were sorted in random order. [#7710](https://github.com/JabRef/jabref/issues/7710)

### Removed

Expand Down
3 changes: 3 additions & 0 deletions src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanelViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
import org.jabref.model.entry.field.Field;
import org.jabref.model.entry.field.FieldFactory;

import java.util.Comparator;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the reviewdog complaint


public class FieldFormatterCleanupsPanelViewModel {

private final BooleanProperty cleanupsDisableProperty = new SimpleBooleanProperty();
Expand All @@ -28,6 +30,7 @@ public class FieldFormatterCleanupsPanelViewModel {
private final ObjectProperty<Formatter> selectedFormatterProperty = new SimpleObjectProperty<>();

public FieldFormatterCleanupsPanelViewModel() {
availableFieldsProperty.sort(Comparator.comparing(Field::getDisplayName));
k3KAW8Pnf7mkmdSMPHz27 marked this conversation as resolved.
Show resolved Hide resolved
}

public void resetToRecommended() {
Expand Down