-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use env to determine python3 location #7447
Conversation
In general, it is recommended to use `#!/usr/bin/env python3` as the shebang instead of the hardcoded `!#/usr/bin/python3`. See <https://stackoverflow.com/a/5709632> for more information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's a nice improvement indeed. Could you please also change the mac version of the script https://github.com/JabRef/jabref/blob/master/buildres/mac/jabrefHost.py and add a short entry to the changelog.
@tobiasdiez Done! Listed the change under Changed, hope thats fine :) |
I thought we had changed this already. Great change. |
I see, I was only able to test it on my mac with Python installed via brew. |
I tried but there were too many error reports. |
So on mac we still should use !#/usr/bin/python3 ? |
The issue was looked at here: JabRef/JabRef-Browser-Extension#177 |
I just confirmed on a brand new Mac. |
Using `/usr/bin/env python3` instead of `/usr/bin/python3` would require the XCode command line developer tools. This is not feasible.
Thanks, and sorry for the misleading suggestion from my side. |
In general, it is recommended to use
#!/usr/bin/env python3
as the shebang instead of the hardcoded!#/usr/bin/python3
.See https://stackoverflow.com/a/5709632 for more information.
Related to JabRef-Browser-Extension #177, especially this comment.