Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logg errors at the Google Scholar fetcher and hide them from the UI #7182

Conversation

JofielB
Copy link
Contributor

@JofielB JofielB commented Dec 13, 2020

Summary

This pull request is related to #6334
This pull request is to resolve the exception raised at the UI when you make a search at Google Scholar.

Changes

Move the error thrown to the logger as is recommended.

Demo

No UI error through when you make a search at Google Scholar
google issie

Error show at the log as a warning
google issue

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor
Copy link
Member

koppor commented Dec 17, 2020

Thank you for the PR. It contains two classes, where only one is relevant for the PR title. For the other PR, throwing a new FetcherException is the "JabRef" style. Adding log output is done at #7075

@koppor koppor closed this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants