Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.beryx.jlink from 2.21.0 to 2.21.1 #6711

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 27, 2020

Bumps org.beryx.jlink from 2.21.0 to 2.21.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

Bumps org.beryx.jlink from 2.21.0 to 2.21.1.

Signed-off-by: dependabot[bot] <support@github.com>
@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 27, 2020

This should fix #5771

@tobiasdiez
Copy link
Member

tobiasdiez commented Jul 27, 2020

The installer size decreased quite enormously and is now < 200 mb, which is good. Need to double-check if the .modules files is indeed removed as well. Moreover, a changelog entry needs to be added... Maybe it fixes #6340 as well.

@tobiasdiez tobiasdiez added this to the v5.1 milestone Jul 27, 2020
@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 27, 2020

I just checked the portable version. No more jars and no mods/modules folder.
It works but I am curious where the jabref stuff is now. //Edit it's all now in a single file in runtime/lib/modules

@Siedlerchr
Copy link
Member

Should we merge this now?

@koppor koppor merged commit e13a7c0 into master Jul 27, 2020
@koppor koppor deleted the dependabot/gradle/org.beryx.jlink-2.21.1 branch July 27, 2020 20:15
@koppor
Copy link
Member

koppor commented Jul 27, 2020

This new version includes the fix beryx/badass-jlink-plugin#51, which fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants