Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced link to Workspace set-up with new one #5896

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Conversation

duelle
Copy link
Contributor

@duelle duelle commented Jan 29, 2020

As the current link just pointed to a page with another link, I'd propose to directly put that second link.

As the current link just pointed to a page with another link, I'd propose to directly put that second link.
@duelle duelle requested a review from koppor January 29, 2020 17:26
@koppor koppor merged commit f53568b into JabRef:master Jan 29, 2020
@koppor
Copy link
Member

koppor commented Jan 29, 2020

Thank you for the action taken! 🎉

Siedlerchr added a commit that referenced this pull request Jan 30, 2020
* master: (297 commits)
  Replace link to Workspace set-up with new one (#5896)
  Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)
  Switch to our IntelliJ config (#5881)
  Bump unirest-java from 3.4.00 to 3.4.01 (#5874)
  Bump junit-vintage-engine from 5.5.2 to 5.6.0 (#5875)
  Bump checkstyle from 8.28 to 8.29 (#5876)
  Bump junit-jupiter from 5.5.2 to 5.6.0 (#5877)
  Bump junit-platform-launcher from 1.5.2 to 1.6.0 (#5878)
  Change \ to /
  Bump byte-buddy-parent from 1.10.6 to 1.10.7 (#5873)
  Fix opening pdf with okular in linux (#5253) (#5855)
  Fixed Test
  Refactored constructors, PreferencesService and some minor improvements.
  Remove ampersand escape when writing to bib file (#5869)
  Fix #5862. It was indeed the throttler (at least it is working now for me) (#5868)
  duplicate query parameter removed (#5865)
  New Crowdin translations (#5864)
  Minor refactoring, and changed comment
  Bump antlr4 from 4.7.2 to 4.8-1 (#5852)
  Reintroducing master table index column (#5844)
  ...
koppor pushed a commit that referenced this pull request Jan 30, 2020
As the current link just pointed to a page with another link, I'd propose to directly put that second link.
Siedlerchr added a commit that referenced this pull request Jan 31, 2020
* upstream/master:
  Update development-strategy.md
  Replace link to Workspace set-up with new one (#5896)
  Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)
  Switch to our IntelliJ config (#5881)
Siedlerchr added a commit that referenced this pull request Jan 31, 2020
…tomizeEntrydlg

* 'customizeEntrydlg' of github.com:JabRef/jabref:
  Replace link to Workspace set-up with new one (#5896)
  Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)
Siedlerchr added a commit that referenced this pull request Feb 3, 2020
* upstream/master:
  Replace link to Workspace set-up with new one (#5896)
  Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)
Siedlerchr added a commit that referenced this pull request Feb 3, 2020
* master:
  reference to issue added (#5911)
  Fix properly resolves OrFields of required fields (#5903)
  IDE setup updated and extended (#5901)
  Squashed 'src/main/resources/csl-styles/' changes from e71363e..c531528
  Fixes problems with managing external file types (issue 5846) (#5894)
  Squashed 'src/main/resources/csl-locales/' changes from 41da445acc..4fa753374e
  Squashed 'src/main/resources/csl-styles/' changes from f0c7374..e71363e
  Update development-strategy.md
  Replace link to Workspace set-up with new one (#5896)
  Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)
Siedlerchr added a commit that referenced this pull request Feb 5, 2020
* Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)

* Fixes #5861
Description:
- Cleanup entries: "Make paths of linked files relative (if possible)" broke web URLs and resulted in various other issues subsequently. This PR fixes this issue.
It has been tested for local files and web urls.

* changelog updated

* refactoring: use existing method isOnlineLink() for checking whether a file link is an online link; improving isOnlineLink()

* Replace link to Workspace set-up with new one (#5896)

As the current link just pointed to a page with another link, I'd propose to directly put that second link.

* update to 13.0.2

Co-authored-by: systemoperator <3658393+systemoperator@users.noreply.github.com>
Co-authored-by: Thomas F. Duellmann <duelle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants