Add tests for "changed" flag #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
force-pushed
the
ensure-no-changes-after-writing
branch
2 times, most recently
from
509e9d6
to
482e4a1
Compare
koppor
added
the
status: ready-for-review
tobiasdiez
requested changes
Nov 19, 2019
koppor
added
status: ready-for-review
koppor
changed the title
koppor
force-pushed
the
ensure-no-changes-after-writing
branch
2 times, most recently
from
eaa9e71
to
b5ac16a
Compare
|
Thank you for the feedback --> Update: This PR not change any functionality, but add tests. - I changed the PR description accordingly. |
koppor
added
the
status: ready-for-review
koppor
changed the title
tobiasdiez
requested changes
Nov 22, 2019
| // modify entry | ||
| entry.setField(StandardField.AUTHOR, "BlaBla"); | ||
|
|
||
| BibDatabaseContext context = new BibDatabaseContext(firstParse.getDatabase(), firstParse.getMetaData(), |
There was a problem hiding this comment.
Only write entry once? Makes the test more straightforward
There was a problem hiding this comment.
This test documents that the databaseWriter does not set/reset flags and stores the new entry format during writing. Thus, I renamed to ...EvenInThePrecenseOfSavedModifications
5 tasks
tobiasdiez
reviewed
Nov 25, 2019
src/test/java/org/jabref/logic/exporter/BibtexDatabaseWriterTest.java
Outdated
Show resolved
Hide resolved
koppor
force-pushed
the
ensure-no-changes-after-writing
branch
3 times, most recently
from
8ea1da3
to
3c7a0a2
Compare
- Add tests - Guard AtomicFileWriter with a try-with-resources during save - use Objects.requireNonNull in DefaultFileUpdateMontitor - add comment - some auto-formattings - Fix typo in comment
koppor
force-pushed
the
ensure-no-changes-after-writing
branch
from
3c7a0a2
to
c900236
Compare
|
All requested changes should now be included. |
tobiasdiez
approved these changes
Nov 27, 2019
koppor
removed
the
status: ready-for-review
koppor
pushed a commit
that referenced
this pull request
Oct 15, 2021
3a6a0a7 Update masarykova-univerzita-pravnicka-fakulta.csl (#5655) 136653a Corrections for Conservation Biology style (#5661) af148f8 Update biophysics-and-physicobiology.csl (#5646) 8842ed1 Create production-and-operations-management.csl (#5654) 6b4965f update style file (#5656) e5f6066 Update to Ruby 3.0.2 (#5657) 61c530c Reindent/reorder (#5653) 118c217 Update gems (#5652) 46cd9ab harvard-university-of-bath.csl: correct et-al-min (#5651) 37ba705 Create focaal-journal-of-global-and-historical-anthropology.csl (#5649) e22b8a5 Create developmental-medicine-and-child-neurology.csl (#5644) f7bc32c Bump nokogiri from 1.11.4 to 1.12.5 (#5640) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 3a6a0a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Do not change any functionality, but add tests.
Add tests for changed
(Follow-up to #5635)