[WIP] Get JabRef running in eclipse #5264

Siedlerchr · 2019-09-01T16:04:55Z

I finally figured out how to make JabRef working with java 11 in eclipse.
Requires eclipse 2019-06 minimum

uncomment java version checker, does not work inside eclipse
TODO: Write up or generate the classpath entries with add opens as well
TODO: mark jmh as test resource folder

Run gradlew eclipse
Go to build path -> Libraries
Move all test related libs to classpath
Move jmh to classpath as well
Go to Source -> Mark src/jmh as test folder
Go to Module dependencies
6.1. Select org.controlsfx.controls in the list
6.2. Add export and opens entry for impl.org.controlsfx.autocompletion, impl.org.controlsfx.skin and org.controlsfx.control.textfield to org.jabref
6.3. Select javafx.controls add epxorts and opens entry for com.sun.javafx.scene.control to org.jabref

JPMS options should look like this:

--add-exports org.controlsfx.controls/impl.org.controlsfx.autocompletion=org.jabref --add-exports org.controlsfx.controls/impl.org.controlsfx.skin=org.jabref --add-exports org.controlsfx.controls/org.controlsfx.control.textfield=org.jabref --add-opens org.controlsfx.controls/impl.org.controlsfx.autocompletion=org.jabref --add-opens org.controlsfx.controls/impl.org.controlsfx.skin=org.jabref --add-opens org.controlsfx.controls/org.controlsfx.control.textfield=org.jabref --add-exports javafx.controls/com.sun.javafx.scene.control=org.jabref --add-opens javafx.controls/com.sun.javafx.scene.control=org.jabref

Create a run/debug configuration for main class org.jabref.JabRefLauncher
In the arguments tab enter this for VM arguments.

-Djabref.theme.css --patch-module test=fastparse_2.12-1.0.0.jar --patch-module test2=fastparse-utils_2.12-1.0.0.jar --patch-module test3=sourcecode_2.12-0.1.4.jar --patch-module org.jabref=build\resources\main --add-exports javafx.controls/com.sun.javafx.scene.control=org.jabref --add-exports org.controlsfx.controls/impl.org.controlsfx.skin=org.jabref --add-opens javafx.controls/javafx.scene.control=org.jabref --add-opens org.controlsfx.controls/org.controlsfx.control.textfield=org.jabref --add-exports javafx.graphics/com.sun.javafx.scene=org.controlsfx.controls --add-exports javafx.graphics/com.sun.javafx.scene.traversal=org.controlsfx.controls --add-exports javafx.graphics/com.sun.javafx.css=org.controlsfx.controls --add-exports javafx.controls/com.sun.javafx.scene.control.behavior=org.controlsfx.controls --add-exports javafx.controls/com.sun.javafx.scene.control=org.controlsfx.controls --add-exports javafx.controls/com.sun.javafx.scene.control.inputmap=org.controlsfx.controls --add-exports javafx.base/com.sun.javafx.event=org.controlsfx.controls --add-exports javafx.base/com.sun.javafx.collections=org.controlsfx.controls --add-exports javafx.base/com.sun.javafx.runtime=org.controlsfx.controls --add-exports javafx.web/com.sun.webkit=org.controlsfx.controls --add-exports javafx.graphics/com.sun.javafx.css=org.controlsfx.controls --add-opens javafx.controls/javafx.scene.control.skin=org.controlsfx.controls --add-opens javafx.graphics/javafx.scene=org.controlsfx.controls"

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

uncomment java version checker, does not work inside eclipse TODO: Write up or generate the classpath entries with add opens as well TODO: mark jmh as test resource folder

* upstream/master: Bump com.github.ben-manes.versions from 0.22.0 to 0.24.0 (#5272) Bump src/main/resources/csl-styles from `f5a7311` to `fa125ec` Bump richtextfx from 0.10.1 to 0.10.2 Bump guava from 28.0-jre to 28.1-jre Bump org.beryx.jlink from 2.15.0 to 2.15.1 Bump checkstyle from 8.23 to 8.24 Bump jakarta.annotation-api from 1.3.4 to 1.3.5 fixed dependency on gui and added archUnitTest capsulated all usages of MaterialDesignIcon in gui/icons and removed IconFactory again added all used icons to IconTheme workaround for issue #5245, added custom Factory class adjusted gitignore to properly match icon classes

tobiasdiez · 2019-09-04T22:33:25Z

.gitmodules

@@ -1,6 +1,3 @@
-[submodule "src/main/resources/csl-styles"]


What's the reason for this change?

Hmm this was not intended

tobiasdiez · 2019-09-04T22:34:46Z

src/main/java/org/jabref/JabRefMain.java

@@ -48,7 +48,7 @@ public static void main(String[] args) {
    public void start(Stage mainStage) throws Exception {
        try {
            // Fail on unsupported Java versions
-            ensureCorrectJavaVersion();


Could you please re-enable this? Did it work before in eclipse?

tobiasdiez · 2019-09-05T06:30:26Z

I have reverted the merge for the moment.

Siedlerchr · 2019-09-05T06:31:02Z

thanks I will investitage further.

30fb68e Create BJEDIS-ABNT-Number (#5255) aafb868 Update geochimica-et-cosmochimica-acta.csl (#5321) 60ba25f british-journal-of-anaesthesia.csl: add comma delimiter between non-sequential citations eg. 1 4 7-9 -> 1, 4, 7-9 (#5313) 67e6564 Reindent/reorder (#5318) c0d2a39 Ruby 3.0.0 (#5309) 76d60ff Update harvard-anglia-ruskin-university.csl (#5310) bc18ac9 Create journal-for-the-study-of-the-new-testament.csl (#5312) aff602c Update journal-of-food-protection.csl (#5315) 4503826 Update muscle-and-nerve.csl (#5317) 3bed58e constant redefinition 4d718a0 update documentaiton link fa99e2f add comma delimiter between succesive numbers d396f8b Allow privileged testing of PRs (#5307) 43b22c7 Update masarykova-univerzita-pravnicka-fakulta.csl, pravnik.csl, iso690-full-note-cs.csl (#5308) 8a31c1e Update copernicus-publications.csl (#5303) 96760bb Update anabases.csl (#5304) 744de6d removed locale (#5300) 7eb0d60 Update aviation-space-and-environmental-medicine.csl (#5297) 2769970 Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5298) 51e3f4c Update harvard-university-of-bath.csl (#5299) 5fce84f Create cns-spectrums.csl (#5290) bb8082c Create journal-of-surgical-oncology.csl (#5259) 90c13ae Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5288) 4bab1ad Update early-christianity.csl (#5289) 636ba78 Update tatup-zeitschrift-fur-technikfolgenabschatzung-in-theorie-und-… (#5291) b7cc511 Create biotechnologia.csl (#5292) 5bab881 Update journal-of-orthopaedic-trauma.csl (#5287) 5943413 Fix locales (#5285) 302bd65 Update universite-du-quebec-a-montreal-departement-dhistoire.csl (#5286) 860ae48 Add Haaga-Helia University of Applied Sciences Harvard style (#5282) c1c27de Localize Metropolia style title (#5283) 508da89 Fix presentation for Methods of Information in Medicine (#5284) 53e1d0b Create geschichte-und-gesellschaft.csl (#5216) d7ed0cb Create universite-de-geneve-departement-de-francais-moderne.csl (#5212) 80c404b Update journal-of-orthopaedic-trauma.csl (#5281) 20c143a Adding publishers' names (#5280) 6e5cd59 Update sodertorns-hogskola-oxford.csl (#5279) 52f2621 dollar-brace a260294 Create journal-of-microbiology-and-biotechnology.csl (#5277) 1fc979e Create qeios.csl (#5261) 86347b7 GH does this for us -- again, sorry guys b649589 Create experimental-biology-and-medicine.csl (#5276) 12ae0b1 Revert "tell sheldon about the job state" bdcae89 tell sheldon about the job state 1240067 Add Vegetation classification and Survey (#5271) 6f398f0 Major update to Gallia.csl (#5269) 2a74b2c Update filters.yaml (#5273) 20046d2 Update spec_helper.rb (#5272) 2ee0dd8 Create the-sociological-review.csl (#5260) 5b8d09c move filters to inert file to pacify Sheldon (#5268) e5f3315 Localize more language descriptors in style titles (#5270) bfd2942 Localize more language descriptors in style titles (#5267) 35e276f Fix variable used for the label after indication of number of pages (#5240) 60f6371 Create Universidade-do-Estado-do-Rio-de-Janeiro.csl (#5247) d8cc2ae Create the-journal-of-the-acoustical-society-of-america-numeric.csl (#5256) 92259c1 Create journal-of-financial-and-quantitative-analysis.csl (#5264) 6ba8aab Create journal-of-vestibular-research.csl (#5258) 0c88f41 Update european-journal-of-international-law.csl (#5265) cff5abc Put language descriptor within parentheses 4a62709 Update monash-university-harvard.csl (#5253) 64fd1aa Localize more language descriptors in style titles (#5262) f6519cb Localize more language descriptors in style titles (#5257) 170ccae tiny fixes for universitat-basel-iberoromanistik.csl (#5254) b7284c9 Localize more language descriptors in style titles (#5252) f4ef858 Add "Baishideng Publishing Group" dependents (#5251) 266e7c3 Make world-journal-of-hepatology.csl to bpg.csl parent (#5243) 9129098 fix small formatting issues for mclc.csl (#5229) 5d9560b Create crispr-journal.csl (#5249) a217299 Change "Czech" to "Čeština" in titles (#5248) 4fef39a Create journal-of-open-research-software.csl (#5245) 2bff1a6 Change "Dutch" to "Nederlands" in titles (#5242) f28da34 Update spec_helper.rb (#5246) e0e977c Move content from wiki pages to markdown files (#5194) 018304c Update universite-de-montreal-apa.csl (#5239) 3b83e5c Create sodertorns-hogskola-oxford.csl (#5234) 1335378 Stop notifying 8827 port on Zotero servers (#5237) f079b2a Update author-year disambiguation (#5238) 60bb0c9 Update technische-universitat-dresden-medizin.csl (#5236) e374657 Create Leidraad voor juridische auteurs 2019 (Dutch) (#5223) 0450d89 Add new style for U of Mannheim, Germanistische Linguistik (#5228) 81f0689 Create health-sports-rehabilitation-medicine.csl (#5233) c152a44 Update Gemfile.lock (#5235) 748e1eb Update geochimica-et-cosmochimica-acta.csl (#5231) 06b9ce8 Update zeitschrift-fur-theologie-und-philosophie.csl (#5230) e747cb1 haute-ecole-de-gestion-de-geneve: Make polyglot & et al changes 4cfedb7 Create universite-de-sherbrooke-histoire.csl (#5210) a96a61e Update journal-of-glaciology.csl (#5222) c6a94c9 Add Journal of Human Rights (#5227) c5c9c5f Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5214) ffb7aa6 Create comparativ.csl (#5215) e07329a Update lancaster-university-harvard.csl (#5220) c075d41 Update mimesis-edizioni.csl (#5219) 502970a Removed space in year only citation (#5218) 13e8c6b Update acta-scientiae-veterinariae.csl (#5209) 0699da6 Remake mammallia.csl for Oct/2020 guidelines. (#5207) b2dd3fd Update journal-of-international-business-studies.csl (#5217) dd52bfe Update quaternaire.csl (#5199) ccb1b0d rebuild webpage and article-journal citations in journal-of-forensic-sciences.csl (#5203) f02f4fb Create pedosphere.csl (#5196) 70dd87a Create open-gender-journal.csl (#5198) d272998 Create the-quarterly-journal-of-economics.csl (#5197) d27cab3 fix locale issues, add cite-locator (#5206) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 30fb68e

first part of java 11 fix

d1f55e9

uncomment java version checker, does not work inside eclipse TODO: Write up or generate the classpath entries with add opens as well TODO: mark jmh as test resource folder

Siedlerchr changed the title ~~first part of java 11 fix~~ [WIP] Get JabRef running in eclipse Sep 1, 2019

Siedlerchr merged commit 21ab1d2 into master Sep 4, 2019

Siedlerchr deleted the eclipsejava11 branch September 4, 2019 18:03

tobiasdiez reviewed Sep 4, 2019

View reviewed changes

tobiasdiez mentioned this pull request Sep 5, 2019

Revert "[WIP] Get JabRef running in eclipse" #5280

Merged

tobiasdiez restored the eclipsejava11 branch September 5, 2019 06:29

stefan-kolb deleted the eclipsejava11 branch November 29, 2019 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Get JabRef running in eclipse #5264

[WIP] Get JabRef running in eclipse #5264

Siedlerchr commented Sep 1, 2019 •

edited

Loading

tobiasdiez Sep 4, 2019

Siedlerchr Sep 5, 2019

tobiasdiez Sep 4, 2019

tobiasdiez commented Sep 5, 2019

Siedlerchr commented Sep 5, 2019

[WIP] Get JabRef running in eclipse #5264

[WIP] Get JabRef running in eclipse #5264

Conversation

Siedlerchr commented Sep 1, 2019 • edited Loading

tobiasdiez Sep 4, 2019

Choose a reason for hiding this comment

Siedlerchr Sep 5, 2019

Choose a reason for hiding this comment

tobiasdiez Sep 4, 2019

Choose a reason for hiding this comment

tobiasdiez commented Sep 5, 2019

Siedlerchr commented Sep 5, 2019

Siedlerchr commented Sep 1, 2019 •

edited

Loading