Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resolve duplicate keys dialog #4696

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Remove resolve duplicate keys dialog #4696

merged 1 commit into from
Feb 23, 2019

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Feb 23, 2019 •
edited by Siedlerchr
Loading

Fixes #4614

Removes the resolve duplicate keys dialog. This feature is made obsolete by the integrity check and the user can generate new keys very simply (for all entries or only for the duplicated ones) through the entry editor and/or menu.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 23, 2019
@Siedlerchr
Copy link
Member

Well, however on import there should be a warning and the option to resolve duplicate keys. It's essential to discover duplicates

@tobiasdiez
Copy link
Member Author

tobiasdiez commented Feb 23, 2019 •
edited
Loading

@Siedlerchr such a feature wasn't implemented (the only check was when opening a database) and is obsolete with my other PR #4692, where now keys are automatically generated for every imported entry. Duplicate entries are also highlighted in the import dialog.

@Siedlerchr
Copy link
Member

Okay, then I see no problem!

@Siedlerchr Siedlerchr merged commit 4deb581 into master Feb 23, 2019
@Siedlerchr Siedlerchr deleted the removeDuplicateKeyDialog branch February 23, 2019 16:49
@Siedlerchr Siedlerchr mentioned this pull request Feb 24, 2019
Closed
36 tasks
Siedlerchr added a commit that referenced this pull request Feb 24, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into libraryproperties…
466f40f 
…tofx

* upstream/master:
  Catch NumberFormatException in BibTeXML exporter (#4698)
  Remove resolve duplicate keys dialog (#4696)
  fixes #4610. Changed the way the GroupDialog description is displayed.  (#4660)
  Bump slf4j-api from 1.8.0-beta2 to 1.8.0-beta4 (#4675)
@luizphilipe2 luizphilipe2 mentioned this pull request Jun 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BibTexKey Duplicate Check throws NPE
2 participants
@tobiasdiez @Siedlerchr