Fix showing multiple icons for one menu entry - fixes #4384

[topalavlad]

It currently only applies to the Rank menu; the sub-entries were only showing the first star instead of 5 stars

Since SpecialFieldMenuAction has been removed and in RightClickMenu the following has been removed, the icons are not set correctly anymore.

    public static void populateSpecialFieldMenu(JMenu menu, SpecialField field, JabRefFrame frame) {
        SpecialFieldViewModel viewModel = new SpecialFieldViewModel(field);
        menu.setText(viewModel.getLocalization());
        menu.setIcon(viewModel.getRepresentingIcon());
        for (SpecialFieldValue val : field.getValues()) {
            menu.add(new SpecialFieldMenuAction(new SpecialFieldValueViewModel(val), frame));
        }
    }

The new way of working is through ActionFactory which uses setGraphic() instead:

    private static void setGraphic(MenuItem node, Action action) {
        node.graphicProperty().unbind();
        action.getIcon().ifPresent(icon -> node.setGraphic(icon.getGraphicNode()));
    }

Since the only composite icons are the ones used for rank, using the full unicode field of Node instead of only the unicode of the first icon won't affect other Actions.

    @Override
    public Node getGraphicNode() {
        GlyphIcons icon = icons.get(0);

        Text text = new Text(icon.unicode()); //Replaced with unicode
        text.getStyleClass().add("glyph-icon");
        text.setStyle(String.format("-fx-font-family: %s;", icon.fontFamily()));

        color.ifPresent(color -> text.setStyle(text.getStyle() + String.format("-fx-fill: %s;", ColorUtil.toRGBCode(color))));
        return text;
    }

[tobiasdiez]

Thanks a lot for your contribution and the detailed description of the change/your pull request. Looking forward to see more PRs from you ;-)

[Siedlerchr]

Yeah! Thanks for your contribution! 👍