Improve preferences #4280
Merged
Improve preferences #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
6 tasks
Siedlerchr
reviewed
Aug 22, 2018
| for (EntryType type : EntryTypes.getAllValues(mode)) { | ||
| textFields.put(type.getName().toLowerCase(Locale.ROOT), textFieldArray[y]); | ||
| y++; | ||
| } | ||
|
|
||
| Button help1 = new Button("?"); | ||
| help1.setOnAction(e->new HelpAction(Localization.lang("Help on key patterns"), HelpFile.BIBTEX_KEY_PATTERN).getHelpButton().doClick()); |
There was a problem hiding this comment.
You need to move this help and the reset all button beneath the loop, with rowindex+3 otherwise it will be somewhere in the middle because it still uses hardcoded value. That's what I discovered while fixing it in the other PR.
Siedlerchr
reviewed
Aug 22, 2018
| } | ||
|
|
||
| public void exportPreferences(Path file) throws JabRefException { | ||
| try (OutputStream os = new FileOutputStream(file.toFile())) { |
There was a problem hiding this comment.
Files.newOutputStream(path);
Siedlerchr
reviewed
Aug 22, 2018
| } | ||
|
|
||
| public void importPreferences(Path file) throws JabRefException { | ||
| try (InputStream is = new FileInputStream(file.toFile())) { |
Siedlerchr
reviewed
Aug 22, 2018
| @@ -1912,4 +1920,8 @@ public String getPreviewStyle() { | |||
| return Optional.empty(); | |||
| } | |||
| } | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #4253. Some code cleanup (mainly of the PreferencesDialog class) and stylistic facelifting:
It's still not perfect (especially some of the tabs are still looking horrible), but should be a step in the right direction.
Please merge and not squash.