-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the Swing Dialog to JavaFX #4249
Conversation
Super-Tang
commented
Aug 7, 2018
•
edited
Loading
edited
- Change in CHANGELOG.md described
- Tests created for changes
- Manually tested changed features in running JabRef
- Screenshots added in PR description (for bigger UI changes)
- Ensured that the git commit message is a good one
- Check documentation status (Issue created for outdated help page at help.jabref.org?)
We convert part of the swing dialog to javafx. The dialog we are trying to change is Options->Preferences. |
Oh wow, with the preferences you actually took the most complex of all dialogs ;-). From what I can see, you already made good progress. Nice! |
In addition to what Tobias says, in future please create a new branch for a feature or issue to work on and to commit to. This make it easier for you and us to review the changes. |
What's the relation of this PR with #4253? |
They are the same. I just created a new branch, and pushed my changes to the branch. I will close this PR at once. @tobiasdiez |