Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the Swing Dialog to JavaFX #4249

Closed
wants to merge 21 commits into from
Closed

Conversation

Super-Tang
Copy link
Contributor

@Super-Tang Super-Tang commented Aug 7, 2018


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Super-Tang
Copy link
Contributor Author

We convert part of the swing dialog to javafx. The dialog we are trying to change is Options->Preferences.

@tobiasdiez
Copy link
Member

Oh wow, with the preferences you actually took the most complex of all dialogs ;-). From what I can see, you already made good progress. Nice!
I would suggest you try to merge with the current master so that some of the code changes in master are no longer shown as differences and then I'll have a look and give you feedback.

@Siedlerchr
Copy link
Member

In addition to what Tobias says, in future please create a new branch for a feature or issue to work on and to commit to. This make it easier for you and us to review the changes.

@tobiasdiez
Copy link
Member

What's the relation of this PR with #4253?

@Super-Tang
Copy link
Contributor Author

They are the same. I just created a new branch, and pushed my changes to the branch. I will close this PR at once. @tobiasdiez

@Super-Tang Super-Tang closed this Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants