Reimplement tooltips for file and identifier columns #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
approved these changes
May 5, 2018
Siedlerchr
reviewed
May 6, 2018
| Optional<String> field = entry.getEntry().getField(content); | ||
| if (field.isPresent()) { | ||
| if (FieldName.DOI.equals(content)) { | ||
| return Localization.lang("Open DOI web link (%0)", field.get()); |
There was a problem hiding this comment.
As DOI, Arxiv are not really translateable, I would just add them as parameter, e.g Open %0 Url %1 (at least for arxiv)
|
Thanks again for your contribution! |
florian-beetz
added a commit
that referenced
this pull request
May 8, 2018
* Reimplement tooltips for file and identifier column * Extract not translatable strings out of localization
Siedlerchr
added a commit
that referenced
this pull request
May 10, 2018
…drop * upstream/maintable-beta: (174 commits) Fix ACM fetcher import of entries (#4019) Reimplement tooltips for file and identifier columns (#4011) Add button-icon for union/intersection in the groups side panel (#3954) Update Dependencies (#4012) set look and feel to windows, aqua or nimbus for swing in case fix import remove look and feel New translations JabRef_en.properties (French) (#4009) Fix Look and Feel related issues (#4002) Fix statement in changelog [WIP] Add Text File Export for "Find Unlinked Files" (#3979) Fix IEEE preview does not display month (#3983) Activate context menu on key press (#4004) Improve code layout Fix concurrent modification exception when adding entries to groups Fix build Typo Add fix Rename test Fix #3994 Duplicate unmodifiable list for sorting (#3996) ... # Conflicts: # src/main/java/org/jabref/gui/actions/CleanupAction.java # src/main/java/org/jabref/gui/maintable/MainTable.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3973.
Reimplements tooltips for file-, URL-/DOI- and Eprint-column in the maintable-beta.