Fix tests in maintable beta except L10n #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except L10n
Siedlerchr
added
status: ready-for-review
tobiasdiez
approved these changes
Mar 18, 2018
lenhard
approved these changes
Mar 19, 2018
Siedlerchr
added a commit
that referenced
this pull request
Mar 19, 2018
…esDlg * upstream/maintable-beta: fix failing tests in maintable beta (#3863)
|
Dev Calll decision: Postponed to when 5.0 will be master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some of the failing tests, except the l10n tests.
I am unsure what we do with the L10N issues. Let's discuss this in a devcall.