[WIP] Add support for German months at the normalizer functionality #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
requested changes
Dec 15, 2017
| if (value.equalsIgnoreCase("Maerz")) { | ||
| // this value is not treated by LatexToUnicodeAdapter, so a special handling is required. | ||
| month = Month.getMonthByNumber(3); | ||
| } else { |
There was a problem hiding this comment.
Why don't you use the java 8 DateTimeFormatter for parsing the dates? Much more easier and flexible https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html#predefined
tobiasdiez
reviewed
Dec 15, 2017
| @@ -23,6 +26,31 @@ public String getKey() { | |||
| public String format(String value) { | |||
| Objects.requireNonNull(value); | |||
| Optional<Month> month = Month.parse(value); | |||
|
|
|||
There was a problem hiding this comment.
Since this is about parsing months, it should go into the Month.parse method, right?
|
I wasn't sure, cause this seemed a seldom case. I can move it there.
|
koppor
changed the title
koppor
force-pushed
the
support-german-months
branch
from
ea5956f
to
0294b01
Compare
5 tasks
|
Superseeded by #3734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My library exports BibTeX in a strange format (http://www2.informatik.uni-stuttgart.de/zdi/buecherei/NCSTRL_listings/privat/Kopp_Oliver.bibtex.html). I cannot get this fixed, so JabRef has to.
Screenshots added (for bigger UI changes)gradle localizationUpdate?