Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve date parsing #2731

Merged
merged 19 commits into from
Apr 17, 2017
Merged

Improve date parsing #2731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
30f1c35
Extract date parse logic to new class and slightly improve it
tobiasdiez Apr 11, 2017
2fcda79
Convert MonthUtil to enum
tobiasdiez Apr 12, 2017
d555c92
Add additional possible date format
tobiasdiez Apr 12, 2017
91ed929
Replace indices with numbers in Month
LinusDietz Apr 16, 2017
faa0e5b
fixed camelcase
LinusDietz Apr 16, 2017
dea3424
add javadoc, remove redundant constructor fields
LinusDietz Apr 16, 2017
52a568b
Change month on MSXMLimport to numeric
Siedlerchr Apr 17, 2017
8cacfb7
Use BibEntry#setMonth at RisImporter
koppor Apr 17, 2017
d2d9a97
Use BibEntry#parseMonth at BibTeXConverter
koppor Apr 17, 2017
436645f
Rename getBibtexFormat to getJabRefFormat as this string is something…
koppor Apr 17, 2017
ad3b605
Add test case for month format behavior
koppor Apr 17, 2017
e1e0816
Remove year from RepecNepImporterTest as this case does not seem to a…
koppor Apr 17, 2017
8b4b109
Merge branch 'master' of https://github.com/JabRef/jabref into fixDat…
tobiasdiez Apr 17, 2017
4ee2108
Fix test output
koppor Apr 17, 2017
8020254
Fix RisImporter
koppor Apr 17, 2017
d388645
Extract setDate to new method
tobiasdiez Apr 17, 2017
aeb55a8
Merge branch 'fixDateParsing' of https://github.com/JabRef/jabref int…
tobiasdiez Apr 17, 2017
794322b
Return month in JabRef format
tobiasdiez Apr 17, 2017
7c34880
Fix tests
tobiasdiez Apr 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/logic/msbib/BibTeXConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public static BibEntry convert(MSBibEntry entry) {
}
if (entry.month != null) {
Optional<Month> month = Month.parse(entry.month);
month.ifPresent(parsedMonth -> fieldValues.put(FieldName.MONTH, parsedMonth.getBibtexFormat()));
month.ifPresent(parsedMonth -> fieldValues.put(FieldName.MONTH, parsedMonth.getTwoDigitNumber()));
}
if (entry.number != null) {
fieldValues.put(FieldName.NUMBER, entry.number);
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/org/jabref/logic/importer/fileformat/MsBibImporterTest7.bib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ @Article{Orlowski;2011
title = {Application of Ontology In the ITIL Domain},
journal = {Information Systems Architecture and Technology: Service Oriented Networked Systems},
year = {2011},
month = {mar},
month = {03},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't month = mar the correct format for BibTex?!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only, because many styles define the string mar. At least this is what I read from the discussion at https://tex.stackexchange.com/q/70455/9075.

volume = {5},
issue = {3},
pages = {99--108},
Expand Down