Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaxb context 9539 #11552

Closed
wants to merge 18 commits into from
Closed

Jaxb context 9539 #11552

wants to merge 18 commits into from

Conversation

psyren99
Copy link

@psyren99 psyren99 commented Jul 31, 2024

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@psyren99 psyren99 closed this Jul 31, 2024
@psyren99 psyren99 reopened this Aug 3, 2024
@psyren99 psyren99 marked this pull request as draft August 3, 2024 02:57
@koppor
Copy link
Member

koppor commented Aug 3, 2024

This fixes #9539.

The diff shows strange changes in build.gradle, which I cannot check on my mobile.

@psyren99
Copy link
Author

psyren99 commented Aug 3, 2024

changes were jackson dependencies
I am getting failed test 'cannot generate preview' and no such element

CHANGELOG.md Outdated Show resolved Hide resolved
@koppor
Copy link
Member

koppor commented Aug 4, 2024

changes were jackson dependencies I am getting failed test 'cannot generate preview' and no such element

I assume, you are executing CitaviXmlImporterFilesTest. What else do you execute?

@koppor koppor mentioned this pull request Aug 4, 2024
6 tasks
@koppor
Copy link
Member

koppor commented Aug 4, 2024

@psyren99 Thank you for starting to look into that. While trying to understand your issue, I fixed some (other) code. These fixes were submitted separately at #11571

While working on your code, I came across https://stackoverflow.com/q/43574426/873282. Then I wondered, why the hell we want to introduce another dependency.

Then, I re-read the issue #9539. There was an issue at the discription. The gradle target to remove should be generateCitaviSource not generateEndnoteSource. I fixed that.

Thus, your PR should start with removing generateCitaviSource and the .xsd file. Then, you will see that your code does not compile at all.

I hadded coding hints to the issue desription #9539. Maybe, they help you to work on this.

Hint: More than half of the lines will be changed.

# Conflicts:
#	src/main/java/org/jabref/logic/importer/fileformat/CitaviXmlImporter.java
@koppor
Copy link
Member

koppor commented Aug 6, 2024

We are working to reduce the number of pull requests. Since there is so much left here, please work on it and create a new pull requests as soon as you have something new.

@koppor koppor closed this Aug 6, 2024
@koppor
Copy link
Member

koppor commented Aug 21, 2024

Follow-up PR: #11621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants