Fix detection of soffice.exe #11478
Merged
Fix detection of soffice.exe #11478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Jul 10, 2024
| } | ||
| }) | ||
| // On Windows, the executable is nested in subdirectory "program" | ||
| .map(dir -> dir.resolve("program")) |
There was a problem hiding this comment.
Maybe add a check for Windows there? Not sure under linux (need to check on mac later this evening but there it seems to work out of the box)
There was a problem hiding this comment.
Damn, I was sure, it was called only at the Windos case
Siedlerchr
reviewed
Jul 10, 2024
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| public class OpenOfficePreferences { | |||
|
|
|||
| public static final String DEFAULT_WIN_EXEC_PATH = "C:\\Program Files\\LibreOffice 5\\program"; | |||
There was a problem hiding this comment.
Ah guess they changed this at some point in time
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
Jul 10, 2024
|
works with windows 10 and my laptop distro (arch) out of the box. |
calixtus
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JabRef could not detect
soffice.exeon my machine. I fixed it.Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)