Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete methods #11272

Merged
merged 3 commits into from
May 3, 2024
Merged

Remove obsolete methods #11272

merged 3 commits into from
May 3, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented May 2, 2024

Some small code cleanup

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the type: code-quality Issues related to code or architecture decisions label May 2, 2024
calixtus
calixtus previously approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was forgotten to remove in #9944

@calixtus
Copy link
Member

calixtus commented May 3, 2024

Localization test fails

@Siedlerchr Siedlerchr enabled auto-merge May 3, 2024 18:05
@Siedlerchr Siedlerchr added this pull request to the merge queue May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 09683ed May 3, 2024
21 checks passed
@Siedlerchr Siedlerchr deleted the cleanup branch May 3, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus left review comments

Assignees
No one assigned
Labels
type: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @calixtus @Siedlerchr