-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove download when html file #11227
Conversation
dialogService.notify(Localization.lang("Download was a HTML file. Not adding it.")); | ||
List<LinkedFile> newFiles = new ArrayList<>(entry.getFiles()); | ||
newFiles.remove(linkedFile); | ||
entry.setFiles(newFiles); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this one if there are multiple files attached and only one leads to HTML. Need to see the full source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only removing the current linked File from he current download.
I am getting all existing files from the entry and just remove the current one
To trigger change detection I have to reassign the list
This is a hard issue. Test entry: @Article{,
file = {https://github.com/JabRef/jabref/issues/10149},
} Click on "download File" Then, the whole link is removed: When executing the steps from #10149 (comment), there are two URLs shown in the file dialog: They are removed shortly after. I am working on a fix. |
Fixed |
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Fixes #10149
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)